From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: linville@tuxdriver.com, Felix.Liao@watchguard.com
Subject: Re: [PATCH 3.7] mac80211: fix remain-on-channel (non-)cancelling
Date: Sat, 24 Nov 2012 00:45:03 +0100 [thread overview]
Message-ID: <1353714303.8287.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1353713539-8094-1-git-send-email-johannes@sipsolutions.net> (sfid-20121124_003200_783757_97E6C453)
On Sat, 2012-11-24 at 00:32 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Felix Liao reported that when an interface is set DOWN
> while another interface is executing a ROC, the warning
> in ieee80211_start_next_roc() (about the first item on
> the list having started already) triggers.
>
> This is because ieee80211_roc_purge() calls it even if
> it never actually changed the list of ROC items. To fix
> this, simply remove the function call. If it is needed
> then it will be done by the ieee80211_sw_roc_work()
> function when the ROC item that is being removed while
> active is cleaned up.
I should mention that the only effect of the patch is removing the
warning, other than that the code behaves the same before and after the
patch.
johannes
prev parent reply other threads:[~2012-11-23 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 23:32 [PATCH 3.7] mac80211: fix remain-on-channel (non-)cancelling Johannes Berg
2012-11-23 23:45 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353714303.8287.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Felix.Liao@watchguard.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).