From: Johannes Berg <johannes@sipsolutions.net>
To: Wojciech Dubowik <Wojciech.Dubowik@neratec.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/1] ath9k: Add radiotap vendor specific data example
Date: Sat, 24 Nov 2012 14:44:55 +0100 [thread overview]
Message-ID: <1353764695.9789.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1353667565-4212-1-git-send-email-Wojciech.Dubowik@neratec.com> (sfid-20121123_115242_843402_5FE9C369)
On Fri, 2012-11-23 at 11:46 +0100, Wojciech Dubowik wrote:
> + rxs->vendor_radiotap_bitmap = 0x00000001;
I would recommend adding multiple fields so that it's extensible in the
future or some things can be left out:
field 0 (0x1):
4 x u8, alignment 1 - RSSI data
field 1 (0x2):
4 x u32 + 1 x u16, alignment ? - evm data
Also:
Ness, STBC are going to be standardised.
noise floor is already standardised I think
johannes
next prev parent reply other threads:[~2012-11-24 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 10:46 [RFC 1/1] ath9k: Add radiotap vendor specific data example Wojciech Dubowik
2012-11-24 11:22 ` Mohammed Shafi
2012-11-26 12:16 ` Wojciech Dubowik
2012-11-24 13:44 ` Johannes Berg [this message]
2012-11-26 12:18 ` Wojciech Dubowik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353764695.9789.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Wojciech.Dubowik@neratec.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).