Re: RFC[1/2]mac80211: Add Statistic to debugfs

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2012-11-23 at 15:26 +0530, Saravana wrote:
> Hi Johannes,
> On 11/23/2012 12:41 PM, Johannes Berg wrote:
> > On Fri, 2012-11-23 at 12:09 +0530, Saravana wrote:
> >
> >>> Also, as you're adding new statistics which are only used when debugfs
> >>> is enabled, you might want to wrap them in #ifdefs so that they're
> >>> only compiled when debugfs support is compiled.
> >
> > [...]
> >> Hence we don't need to wrap this up in #ifdef as it is already taken
> >> care during the directory creation.
> >
> > I think Julian is arguing that you should have the *counters* themselves
> > be under ifdef, and I tend to agree.
> >
> When we went through the make file of mac80211, it is seen that the only 
> when CONFIG_MAC80211_DEBUGFS macro is enabled, the files debugfs.c, 
> debugfs_sta.c, debugfs_netdev.c, debugfs_key.c are compiled in.
> 
> So it may not be required to wrap up any piece of code in these files 
> are they will not be compiled in the first place when the macro 
> CONFIG_MAC80211_DEBUGFS is disabled.

You're thinking of the wrong code -- Julian was saying the *counters*
themselves could be ifdef'ed.

I'd say you don't want to ifdef every single counter, but check which
ones could be expensive to keep etc.

johannes