Re: [RFC] mac80211: re-organize the rx rate calculation logic

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2012-11-26 at 04:17 -0800, saravanad@posedge.com wrote:
> Mac80211: currently the logic to calculate the rx rate is accessible 
> only in the cfg.c as the rate_idx_to_bitrate() is static function.
> The rx rate calculation might be needed by other files(modules) of 
> mac80211(possibly debugfs). So grouping the rx rate calculation logic to
> a separate function which can be accessed from other files. This change 
> will make the rx rate calculation implementation similar to tx rate.

Generally, this seems fine. Your patches are line-wrapped though.

> Signed-off-by: Saravana <saravanad@posedge.com>
> ---
> The diff file is generated from wireless-testing git tree.

I just changed this code in mac80211-next and would appreciate if you
would rebase onto that.

> +void sta_set_rate_info_rx(struct sta_info *sta, struct rate_info 
> *rinfo)
> +{
> +	rinfo->flags = 0;
> +	if (sta->last_rx_rate_flag & RX_FLAG_HT)
> +		rinfo->flags |= RATE_INFO_FLAGS_MCS;
> +	if (sta->last_rx_rate_flag & RX_FLAG_40MHZ)
> +		rinfo->flags |= RATE_INFO_FLAGS_40_MHZ_WIDTH;
> +	if (sta->last_rx_rate_flag & RX_FLAG_SHORT_GI)
> +		rinfo->flags |= RATE_INFO_FLAGS_SHORT_GI;
> +	rate_idx_to_bitrate(rinfo, sta, sta->last_rx_rate_idx);
> +
> +}
>   static void sta_set_sinfo(struct sta_info *sta, struct station_info 
> *sinfo)

That blank line is in the wrong spot, it should be after the closing
bracket :)

johannes