From: Johannes Berg <johannes@sipsolutions.net>
To: Mahesh Palivela <maheshp@posedge.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: Remove unused VHT chan code
Date: Thu, 29 Nov 2012 10:06:50 +0100 [thread overview]
Message-ID: <1354180010.9557.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1354179955.9557.1.camel@jlt4.sipsolutions.net> (sfid-20121129_100538_966311_BCCEF54F)
On Thu, 2012-11-29 at 10:05 +0100, Johannes Berg wrote:
> On Thu, 2012-11-29 at 14:28 +0530, Mahesh Palivela wrote:
> > On 11/29/2012 02:22 PM, Johannes Berg wrote:
> > > On Thu, 2012-11-29 at 14:11 +0530, Mahesh Palivela wrote:
> > >> From: Mahesh Palivela <maheshp@posedge.com>
> > >>
> > >> Cleanup of unused VHT channel config related code.
> > >
> > > Huh, good catch, thanks. Applied.
> >
> > Thanks. Even below also can be removed as cfg80211_chandef_usable()
> > checks this at the beginning.
> >
> > if (!cfg80211_chandef_valid(chandef))
> > return -EINVAL;
>
> Hmm good point I'll roll that in.
No actually it can't, cfg80211_chandef_usable() triggers a warning which
we can't do if userspace just sends invalid information; however it's
doing that for all other in-kernel users intentionally.
johannes
next prev parent reply other threads:[~2012-11-29 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 8:41 [PATCH] cfg80211: Remove unused VHT chan code Mahesh Palivela
2012-11-29 8:52 ` Johannes Berg
2012-11-29 8:58 ` Mahesh Palivela
2012-11-29 9:05 ` Johannes Berg
2012-11-29 9:06 ` Johannes Berg [this message]
2012-11-29 11:58 ` Mahesh Palivela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354180010.9557.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=maheshp@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).