linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Saravana <saravanad@posedge.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add debugfs file for last rx rate
Date: Thu, 29 Nov 2012 15:34:12 +0100	[thread overview]
Message-ID: <1354199652.879.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <50B77013.6040508@posedge.com>

On Thu, 2012-11-29 at 19:54 +0530, Saravana wrote:
> Add a debugfs file showing the rate at which
> the last packet is received.

Applied, but:

> +static ssize_t sta_last_rx_rate_read(struct file *file, char __user *userbuf,
> +				      size_t count, loff_t *ppos)

fixed indentation here


> +	return mac80211_format_buffer(userbuf, count, ppos, "%d.%d MBit/s\n",
> +					rate/10, rate%10);

and here

(and also a bunch of whitespace changes in the other patches)

johannes


  reply	other threads:[~2012-11-29 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-29 14:24 [PATCH] mac80211: add debugfs file for last rx rate Saravana
2012-11-29 14:34 ` Johannes Berg [this message]
2012-11-30  7:57   ` Saravana
2012-12-02 12:38 ` Felix Fietkau
2012-12-03  6:18   ` Saravana
2012-12-03  8:14     ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354199652.879.2.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=saravanad@posedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).