[PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined

[PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined

[Krishna Chaitanya]

Warn once should suffice.

Eg: our driver doesn't support the ampdu_action yet, so
seeing a lot of warnings, hence the check for any
new drivers to avoid messing the kernel log.

Signed-off-by: Chaitanya T K<chaitanya.mgit@gmail.com>
---
 net/mac80211/agg-tx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
index 4152ed1..eb9df22 100644
--- a/net/mac80211/agg-tx.c
+++ b/net/mac80211/agg-tx.c
@@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct
ieee80211_sta *pubsta, u16 tid,

        trace_api_start_tx_ba_session(pubsta, tid);

-       if (WARN_ON(!local->ops->ampdu_action))
+       if (WARN_ON_ONCE(!local->ops->ampdu_action))
                return -EINVAL;

        if ((tid >= IEEE80211_NUM_TIDS) ||

Re: [PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined

[Johannes Berg]

On Wed, 2012-12-05 at 14:43 +0530, Krishna Chaitanya wrote:
> Warn once should suffice.

Indeed :)

> Eg: our driver doesn't support the ampdu_action yet, so
> seeing a lot of warnings, hence the check for any
> new drivers to avoid messing the kernel log.

Please make the subject active voice ("fix the warning storm [...]").

Your patches are all whitespace damaged.

$ git am -s /tmp/\[PATCH\]_mac80211\:_fixing_the_warning_storm_for_budding_chipsets_without_ampdu_action_defined.mbox
Applying: mac80211: fixing the warning storm for budding chipsets without ampdu_action defined
fatal: corrupt patch at line 10
Patch failed at 0001 mac80211: fixing the warning storm for budding chipsets without ampdu_action defined
The copy of the patch that failed is found in:
   /home/johannes/sys/wireless/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

johannes

Re: [PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined

[Krishna Chaitanya]

I have verified the patch with the checkpatch.pl, i think the
whitespace got introduced when i copied the patch from the file to
mail.
The Mail editor (gmail/thunderbird) automatically converts all tabs to spaces.

What should be the ideal settings for VIM editor and lets say gmail/thunderbird.

for VIM i have done:

set tabstop=4
set shiftwidth=4
set expandtab

Is there any thing extra i need to do? a little newbie help would be great :-)

On Wed, Dec 5, 2012 at 2:47 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Wed, 2012-12-05 at 14:43 +0530, Krishna Chaitanya wrote:
>> Warn once should suffice.
>
> Indeed :)
>
>> Eg: our driver doesn't support the ampdu_action yet, so
>> seeing a lot of warnings, hence the check for any
>> new drivers to avoid messing the kernel log.
>
> Please make the subject active voice ("fix the warning storm [...]").
>
> Your patches are all whitespace damaged.
>
> $ git am -s /tmp/\[PATCH\]_mac80211\:_fixing_the_warning_storm_for_budding_chipsets_without_ampdu_action_defined.mbox
> Applying: mac80211: fixing the warning storm for budding chipsets without ampdu_action defined
> fatal: corrupt patch at line 10
> Patch failed at 0001 mac80211: fixing the warning storm for budding chipsets without ampdu_action defined
> The copy of the patch that failed is found in:
>    /home/johannes/sys/wireless/.git/rebase-apply/patch
> When you have resolved this problem, run "git am --resolved".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
> johannes
>

Re: [PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined

[Johannes Berg]

On Wed, 2012-12-05 at 16:37 +0530, Krishna Chaitanya wrote:
> I have verified the patch with the checkpatch.pl, i think the
> whitespace got introduced when i copied the patch from the file to
> mail.
> The Mail editor (gmail/thunderbird) automatically converts all tabs to spaces.
> 
> What should be the ideal settings for VIM editor and lets say gmail/thunderbird.
> 
> for VIM i have done:
> 
> set tabstop=4
> set shiftwidth=4
> set expandtab
> 
> Is there any thing extra i need to do? a little newbie help would be great :-)

There's some information on Thunderbird here:
http://www.kernel.org/doc/Documentation/email-clients.txt

I don't use it myself so don't really know if it's accurate.

johannes

Re: [PATCH] mac80211: fixing the warning storm for budding chipsets without ampdu_action defined

[Seth Forshee]

On Wed, Dec 05, 2012 at 04:37:19PM +0530, Krishna Chaitanya wrote:
> I have verified the patch with the checkpatch.pl, i think the
> whitespace got introduced when i copied the patch from the file to
> mail.
> The Mail editor (gmail/thunderbird) automatically converts all tabs to spaces.
> 
> What should be the ideal settings for VIM editor and lets say gmail/thunderbird.
> 
> for VIM i have done:
> 
> set tabstop=4
> set shiftwidth=4
> set expandtab

That's not correct for editing kernel source. You should have:

 set tapstop=8
 set shiftwidth=8
 set noexpandtab

Seth