From: Johannes Berg <johannes@sipsolutions.net>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Wey-Yi Guy <wey-yi.w.guy@intel.com>
Subject: Re: [PATCH 12/12] iwlwifi: Use standard #defines for PCIe Capability ASPM fields
Date: Wed, 05 Dec 2012 22:26:39 +0100 [thread overview]
Message-ID: <1354742799.24513.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAErSpo4UuT=_dXqoaGttFxY05Arvm9AhoTBsZhks16C-ZDctAw@mail.gmail.com> (sfid-20121205_222037_899929_816BCEB4)
On Wed, 2012-12-05 at 14:20 -0700, Bjorn Helgaas wrote:
> On Wed, Dec 5, 2012 at 2:04 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Wed, 2012-12-05 at 13:58 -0700, Bjorn Helgaas wrote:
> >> Use the standard #defines rather than creating local definitions for
> >> PCIe Capability ASPM fields.
> >
> > I'll pick up the iwlwifi ones if you want, or do you want to merge them
> > somewhere centrally instead?
>
> They do depend on a previous patch that adds the #defines to
> include/uapi/linux/pci_regs.h
> (http://marc.info/?l=linux-pci&m=135474107109010&w=2).
>
> I think I'll merge at least the PCI core parts of this via my PCI tree
> in the v3.8 merge window next week. If it won't cause conflicts for
> you, I could include the iwlwifi bits there, too. If it does, at
> least the #define will exist and you can merge it at your leisure.
Ok, that's fine, feel free to include the iwlwifi bits.
Acked-by: Johannes Berg <johannes.berg@intel.com>
:)
johannes
prev parent reply other threads:[~2012-12-05 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121205205724.13851.50508.stgit@bhelgaas.mtv.corp.google.com>
2012-12-05 20:58 ` [PATCH 08/12] ath9k: Use standard #defines for PCIe Capability ASPM fields Bjorn Helgaas
2012-12-05 20:58 ` [PATCH 09/12] iwlegacy: collapse wrapper for pcie_capability_read_word() Bjorn Helgaas
2012-12-06 8:19 ` Stanislaw Gruszka
2012-12-05 20:58 ` [PATCH 10/12] iwlwifi: " Bjorn Helgaas
2012-12-05 20:58 ` [PATCH 11/12] iwlegacy: Use standard #defines for PCIe Capability ASPM fields Bjorn Helgaas
2012-12-06 8:20 ` Stanislaw Gruszka
2012-12-05 20:58 ` [PATCH 12/12] iwlwifi: " Bjorn Helgaas
2012-12-05 21:04 ` Johannes Berg
2012-12-05 21:20 ` Bjorn Helgaas
2012-12-05 21:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354742799.24513.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bhelgaas@google.com \
--cc=ilw@linux.intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).