From: Joe Perches <joe@perches.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Linux Wireless List <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V2 05/11] brcmfmac: error messages should not be suppressed
Date: Sun, 09 Dec 2012 10:32:19 -0800 [thread overview]
Message-ID: <1355077939.19224.25.camel@joe-AO722> (raw)
In-Reply-To: <50C05B64.5050702@broadcom.com>
On Thu, 2012-12-06 at 09:46 +0100, Arend van Spriel wrote:
> On 12/06/2012 07:32 AM, Joe Perches wrote:
> > On Wed, 2012-12-05 at 22:28 +0100, Arend van Spriel wrote:
> >> The call to brcmf_dbg(ERROR, ...) only resulted in a log message
> >> when compiled with -DDEBUG. Error messages are valuable for resolving
> >> issues so this patch replaces it with brcmf_err(...) so they always
> >> end up in the log.
> > []
> >
> >> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h b/drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h
> > []
> >> @@ -35,20 +34,11 @@
> >>
> >> #if defined(DEBUG)
> >>
> >> -#define brcmf_dbg(level, fmt, ...) \
> >> -do { \
> >> - if (BRCMF_ERROR_VAL == BRCMF_##level##_VAL) { \
> >> - if (brcmf_msg_level & BRCMF_##level##_VAL) { \
> >> - if (net_ratelimit()) \
> >> - pr_debug("%s: " fmt, \
> >> - __func__, ##__VA_ARGS__); \
> >> - } \
> >> - } else { \
> >> - if (brcmf_msg_level & BRCMF_##level##_VAL) { \
> >> - pr_debug("%s: " fmt, \
> >> - __func__, ##__VA_ARGS__); \
> >> - } \
> >> - } \
> >> +#define brcmf_err(fmt, ...) pr_err("%s: " fmt, __func__, ##__VA_ARGS__)
> >
> > You still lost the net_ratelimit() for the DEBUG case.
> >
> > This brcmf_err macro should probably be in dhd.h,
> > not in a debug header and not guarded by DEBUG at all.
>
> I thought I explained why in my email response to you, but now I don't
> see that one on the mailing list archives (attached now). When we are
> debugging we do not want error messages to be filtered.
I suppose that depends on how flooded the dmesg log
could be by these. I presumed that because all
brcmf_dbg uses were debug only messages, and only
BRCMF_ERROR_VAL messages were rate limited, then it
was because flooding these messages at debug wasn't
useful.
I presume that's still true.
next prev parent reply other threads:[~2012-12-09 18:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 14:25 [PATCH 00/11] brcm80211: cleanup patches Arend van Spriel
2012-12-05 14:25 ` [PATCH 01/11] brcmfmac: rework bus interface Arend van Spriel
2012-12-05 14:25 ` [PATCH 02/11] brcmsmac: fix uninitialized variable warning on arm architecture Arend van Spriel
2012-12-05 14:25 ` [PATCH 03/11] brcmfmac: use one list of event defintions Arend van Spriel
2012-12-05 14:25 ` [PATCH 04/11] brcmsmac: radio on led support Arend van Spriel
2012-12-05 15:09 ` Hauke Mehrtens
2012-12-05 17:49 ` Arend van Spriel
2012-12-05 21:00 ` Arend van Spriel
2012-12-05 14:25 ` [PATCH 05/11] brcmfmac: error messages should not be suppressed Arend van Spriel
2012-12-05 14:41 ` Joe Perches
2012-12-05 21:28 ` [PATCH V2 " Arend van Spriel
2012-12-06 6:32 ` Joe Perches
2012-12-06 8:46 ` Arend van Spriel
2012-12-09 18:32 ` Joe Perches [this message]
2012-12-07 9:59 ` Arend van Spriel
2012-12-07 9:49 ` [PATCH V3 " Arend van Spriel
2012-12-05 14:25 ` [PATCH 06/11] brcmfmac: consolidate debug macros in wl_cfg80211 Arend van Spriel
2012-12-05 14:26 ` [PATCH 07/11] brcmfmac: replace WL_ERR() with brcmf_err() Arend van Spriel
2012-12-05 14:26 ` [PATCH 08/11] brcmfmac: replace WL_INFO() macro Arend van Spriel
2012-12-05 14:26 ` [PATCH 09/11] brcmfmac: remove WL_TRACE() macro Arend van Spriel
2012-12-05 14:26 ` [PATCH 10/11] brcmfmac: remove WL_SCAN() macro Arend van Spriel
2012-12-05 14:26 ` [PATCH 11/11] brcmfmac: remove WL_CONN() macro Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355077939.19224.25.camel@joe-AO722 \
--to=joe@perches.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox