From: Johannes Berg <johannes@sipsolutions.net>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH V4 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL
Date: Fri, 28 Dec 2012 14:09:10 +0100 [thread overview]
Message-ID: <1356700150.9922.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1356690070-26612-2-git-send-email-vthiagar@qca.qualcomm.com>
On Fri, 2012-12-28 at 15:51 +0530, Vasanthakumar Thiagarajan wrote:
> + * @acl_type: ACL policy that driver supports,
> + * see &enum nl80211_acl_policy_attr.
That doesn't make a lot of sense, in particular not the way you use it.
What if a driver supports a blacklist but not a whitelist? It seems that
it should be a bitfield. Also setting a default that isn't "unsupported"
is a bad idea.
> + NL80211_ATTR_ACL_POLICY,
> +
> + NL80211_ATTR_MAC_ADDRS,
> +
> + NL80211_ATTR_MAC_ACL_MAX,
> +
> + NL80211_ATTR_ACL_TYPE,
> + if (WARN_ON((wiphy->acl_type <= NL80211_ACL_POLICY_MAX) &&
So basically you could remove the acl_type field completely.
I think maybe if you want to continue supporting the white- & blacklist
you should change it back to nested attributes, but treat the blacklist
there as an optimisation and ignore it for feature advertising.
johannes
next prev parent reply other threads:[~2012-12-28 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 10:21 [PATCH V4 1/2] cfg80211: Move the definition of struct mac_address up Vasanthakumar Thiagarajan
2012-12-28 10:21 ` [PATCH V4 2/2] cfg80211/nl80211: Enable drivers to implement mac address based ACL Vasanthakumar Thiagarajan
2012-12-28 11:31 ` Johannes Berg
2012-12-28 12:56 ` Johannes Berg
2012-12-31 5:14 ` Vasanthakumar Thiagarajan
2013-01-02 12:56 ` Johannes Berg
2013-01-03 5:47 ` Vasanthakumar Thiagarajan
2013-01-03 9:54 ` Johannes Berg
2012-12-28 13:09 ` Johannes Berg [this message]
2012-12-31 5:19 ` Vasanthakumar Thiagarajan
2013-01-02 12:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356700150.9922.7.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).