From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org
Subject: Re: [PATCH v2] mac80211: dynamic short slot time for MBSSs
Date: Sun, 27 Jan 2013 00:48:21 +0100 [thread overview]
Message-ID: <1359244101.9086.8.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAG6hwVNFbuQLGhLECpjoFVevf+SunUY62RNAxmJSum34XGH+gw@mail.gmail.com> (sfid-20130127_003645_161477_2208DDCC)
On Sat, 2013-01-26 at 15:36 -0800, Thomas Pedersen wrote:
> Huh, that's actually pretty nice.
:)
> I don't really get why the
> for_each_set_bit() is broken on big endian 64-bit systems, but hey
> this approach takes care of that concern :)
Because then you're taking the address of a 32-bit variable, and
treating it as an unsigned long (64 bits), so if you iterate its 64 bits
then you'll get some random other stuff from the stack (on both big and
little endian actually, I thought you were limiting it to n_bitrates
then it would work on little endian)
johannes
prev parent reply other threads:[~2013-01-26 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 20:37 [PATCH v2] mac80211: dynamic short slot time for MBSSs Thomas Pedersen
2013-01-26 22:58 ` Johannes Berg
2013-01-26 23:05 ` Johannes Berg
2013-01-26 23:04 ` Johannes Berg
2013-01-26 23:36 ` Thomas Pedersen
2013-01-26 23:48 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359244101.9086.8.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox