From: Johannes Berg <johannes@sipsolutions.net>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Arend van Spriel <arend@broadcom.com>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH 0/7] Improvements to software scanning
Date: Thu, 31 Jan 2013 16:08:36 +0100 [thread overview]
Message-ID: <1359644916.8415.69.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1359644664.8415.68.camel@jlt4.sipsolutions.net> (sfid-20130131_160420_711577_28826127)
On Thu, 2013-01-31 at 16:04 +0100, Johannes Berg wrote:
> On Tue, 2013-01-29 at 17:47 -0600, Seth Forshee wrote:
>
> > Johannes: I have a couple of comments/questions for you related to these
> > patches.
> >
> > First, in the patches I've added an offchan_tx_ok argument to the tx
> > operations, but this seems a little awkward to me since it has to be
> > propogated down through a fairly deep call stack. The alternative idea
> > that occurred to me is to use a tx control flag, but that seems to be
> > pretty crowded. Any thoughts?
>
> Maybe you can bypass by using a flag in struct ieee80211_tx_data, so
> only the first few functions in the call chain need the argument?
> Otherwise, I guess adding a flag should be OK. I know it's crowded, but
> if we really run out I guess we could move all the internal flags etc.
> wholesale ...
Ok no that was wrong ... we can't do that because many flags need to
survive queueing.
johannes
next prev parent reply other threads:[~2013-01-31 15:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 23:47 [PATCH 0/7] Improvements to software scanning Seth Forshee
2013-01-29 23:47 ` [PATCH 1/7] mac80211: Return a status for tx operations Seth Forshee
2013-01-29 23:47 ` [PATCH 2/7] mac80211: Fix tx queue handling during scans Seth Forshee
2013-01-31 15:14 ` Johannes Berg
2013-01-31 16:14 ` Seth Forshee
2013-01-29 23:47 ` [PATCH 3/7] mac80211: Improve error handling for off-channel operation Seth Forshee
2013-01-31 15:15 ` Johannes Berg
2013-01-31 16:17 ` Seth Forshee
2013-01-29 23:47 ` [PATCH 4/7] mac80211: Add flushes before going off-channel Seth Forshee
2013-01-29 23:47 ` [PATCH 5/7] mac80211: Expand powersave configuration flag to be two bits Seth Forshee
2013-01-31 15:20 ` Johannes Berg
2013-01-31 16:33 ` Seth Forshee
2013-01-31 16:53 ` Johannes Berg
2013-01-31 17:18 ` Seth Forshee
2013-01-31 17:50 ` Johannes Berg
2013-02-05 22:51 ` Seth Forshee
2013-02-06 16:48 ` Johannes Berg
2013-02-06 17:09 ` Seth Forshee
2013-02-06 17:44 ` Johannes Berg
2013-02-06 18:02 ` Seth Forshee
2013-02-06 21:30 ` Johannes Berg
2013-01-29 23:47 ` [PATCH 6/7] mac80211: Add off-channel powersave state Seth Forshee
2013-01-29 23:47 ` [PATCH 7/7] brcmsmac: Add support for off-channel powersave Seth Forshee
2013-01-29 23:56 ` Julian Calaby
2013-01-30 5:28 ` Seth Forshee
2013-01-30 19:34 ` [PATCH 0/7] Improvements to software scanning John W. Linville
2013-01-30 21:27 ` Arend van Spriel
2013-01-30 21:53 ` Seth Forshee
2013-01-31 15:04 ` Johannes Berg
2013-01-31 15:08 ` Johannes Berg [this message]
2013-01-31 16:02 ` Seth Forshee
2013-01-31 15:48 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359644916.8415.69.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=seth.forshee@canonical.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).