From: Johannes Berg <johannes@sipsolutions.net>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH 2/7] mac80211: Fix tx queue handling during scans
Date: Thu, 31 Jan 2013 16:14:05 +0100 [thread overview]
Message-ID: <1359645245.8415.72.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1359503255-18270-3-git-send-email-seth.forshee@canonical.com>
On Tue, 2013-01-29 at 17:47 -0600, Seth Forshee wrote:
> + if (offchan_tx_ok) {
unlikely(), this is one of the hottest code paths in mac80211 after
all :-)
> + /*
> + * Always directly transmit off-channel frames
> + * unless the driver has stopped the queues.
> + */
> + if (test_bit(IEEE80211_QUEUE_STOP_REASON_DRIVER,
> + &local->queue_stop_reasons[q])) {
might there be other reasons to TX, i.e. ignore only
STOP_REASON_OFFCHANNEL?
That might be more efficient too:
offchflag = offchan_tx_ok << log2(STOP_REASON_OFFCHANNEL);
> + } else if (local->queue_stop_reasons[q] ||
if (local->queue_stop_reasons[q] & ~offchflag || ...
OTOH, I guess you want a different return value too. But that's in a
relatively unlikely code path again, so might still be better to then
again differentiate within that if.
johannes
next prev parent reply other threads:[~2013-01-31 15:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 23:47 [PATCH 0/7] Improvements to software scanning Seth Forshee
2013-01-29 23:47 ` [PATCH 1/7] mac80211: Return a status for tx operations Seth Forshee
2013-01-29 23:47 ` [PATCH 2/7] mac80211: Fix tx queue handling during scans Seth Forshee
2013-01-31 15:14 ` Johannes Berg [this message]
2013-01-31 16:14 ` Seth Forshee
2013-01-29 23:47 ` [PATCH 3/7] mac80211: Improve error handling for off-channel operation Seth Forshee
2013-01-31 15:15 ` Johannes Berg
2013-01-31 16:17 ` Seth Forshee
2013-01-29 23:47 ` [PATCH 4/7] mac80211: Add flushes before going off-channel Seth Forshee
2013-01-29 23:47 ` [PATCH 5/7] mac80211: Expand powersave configuration flag to be two bits Seth Forshee
2013-01-31 15:20 ` Johannes Berg
2013-01-31 16:33 ` Seth Forshee
2013-01-31 16:53 ` Johannes Berg
2013-01-31 17:18 ` Seth Forshee
2013-01-31 17:50 ` Johannes Berg
2013-02-05 22:51 ` Seth Forshee
2013-02-06 16:48 ` Johannes Berg
2013-02-06 17:09 ` Seth Forshee
2013-02-06 17:44 ` Johannes Berg
2013-02-06 18:02 ` Seth Forshee
2013-02-06 21:30 ` Johannes Berg
2013-01-29 23:47 ` [PATCH 6/7] mac80211: Add off-channel powersave state Seth Forshee
2013-01-29 23:47 ` [PATCH 7/7] brcmsmac: Add support for off-channel powersave Seth Forshee
2013-01-29 23:56 ` Julian Calaby
2013-01-30 5:28 ` Seth Forshee
2013-01-30 19:34 ` [PATCH 0/7] Improvements to software scanning John W. Linville
2013-01-30 21:27 ` Arend van Spriel
2013-01-30 21:53 ` Seth Forshee
2013-01-31 15:04 ` Johannes Berg
2013-01-31 15:08 ` Johannes Berg
2013-01-31 16:02 ` Seth Forshee
2013-01-31 15:48 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359645245.8415.72.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=seth.forshee@canonical.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).