From: Johannes Berg <johannes@sipsolutions.net>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
Christian Lamparter <chunkeey@googlemail.com>,
Ivo van Doorn <IvDoorn@gmail.com>,
Gertjan van Wingerde <gwingerde@gmail.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
Arend van Spriel <arend@broadcom.com>,
Luciano Coelho <coelho@ti.com>,
ath9k-devel@lists.ath9k.org, brcm80211-dev-list@broadcom.com,
users@rt2x00.serialmonkey.com
Subject: Re: [PATCH 5/7] mac80211: Expand powersave configuration flag to be two bits
Date: Thu, 31 Jan 2013 16:20:48 +0100 [thread overview]
Message-ID: <1359645648.8415.77.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1359503255-18270-6-git-send-email-seth.forshee@canonical.com>
On Tue, 2013-01-29 at 17:47 -0600, Seth Forshee wrote:
> +static inline bool ieee80211_is_ps_disabled(struct ieee80211_conf *conf)
> +static inline bool ieee80211_is_ps_enabled(struct ieee80211_conf *conf)
Huh, is that worth the confusion? It seems !enabled should be the same
as disabled, but it's not quite the same, which might be confusing.
> +/**
> + * ieee80211_set_ps_state - set device powersave state
> + *
> + * Sets the powersave state in the supplied device configuration to the
> + * specified state.
> + *
> + * @conf: device configuration
> + * @state: new powersave state. Must be one of the IEEE80211_CONF_PS_*
> + * flags from enum ieee80211_conf_flags.
> + */
> +static inline void ieee80211_set_ps_state(struct ieee80211_conf *conf,
> + u32 state)
> +{
> + conf->flags = (conf->flags & ~IEEE80211_CONF_PS_MASK) |
> + (state & IEEE80211_CONF_PS_MASK);
> +}
I don't think the driver should do this, so the inline shouldn't be
here?
johannes
next prev parent reply other threads:[~2013-01-31 15:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 23:47 [PATCH 0/7] Improvements to software scanning Seth Forshee
2013-01-29 23:47 ` [PATCH 1/7] mac80211: Return a status for tx operations Seth Forshee
2013-01-29 23:47 ` [PATCH 2/7] mac80211: Fix tx queue handling during scans Seth Forshee
2013-01-31 15:14 ` Johannes Berg
2013-01-31 16:14 ` Seth Forshee
2013-01-29 23:47 ` [PATCH 3/7] mac80211: Improve error handling for off-channel operation Seth Forshee
2013-01-31 15:15 ` Johannes Berg
2013-01-31 16:17 ` Seth Forshee
2013-01-29 23:47 ` [PATCH 4/7] mac80211: Add flushes before going off-channel Seth Forshee
2013-01-29 23:47 ` [PATCH 5/7] mac80211: Expand powersave configuration flag to be two bits Seth Forshee
2013-01-31 15:20 ` Johannes Berg [this message]
2013-01-31 16:33 ` Seth Forshee
2013-01-31 16:53 ` Johannes Berg
2013-01-31 17:18 ` Seth Forshee
2013-01-31 17:50 ` Johannes Berg
2013-02-05 22:51 ` Seth Forshee
2013-02-06 16:48 ` Johannes Berg
2013-02-06 17:09 ` Seth Forshee
2013-02-06 17:44 ` Johannes Berg
2013-02-06 18:02 ` Seth Forshee
2013-02-06 21:30 ` Johannes Berg
2013-01-29 23:47 ` [PATCH 6/7] mac80211: Add off-channel powersave state Seth Forshee
2013-01-29 23:47 ` [PATCH 7/7] brcmsmac: Add support for off-channel powersave Seth Forshee
2013-01-29 23:56 ` Julian Calaby
2013-01-30 5:28 ` Seth Forshee
2013-01-30 19:34 ` [PATCH 0/7] Improvements to software scanning John W. Linville
2013-01-30 21:27 ` Arend van Spriel
2013-01-30 21:53 ` Seth Forshee
2013-01-31 15:04 ` Johannes Berg
2013-01-31 15:08 ` Johannes Berg
2013-01-31 16:02 ` Seth Forshee
2013-01-31 15:48 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359645648.8415.77.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=IvDoorn@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=chaoming_li@realsil.com.cn \
--cc=chunkeey@googlemail.com \
--cc=coelho@ti.com \
--cc=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
--cc=senthilb@qca.qualcomm.com \
--cc=seth.forshee@canonical.com \
--cc=sgruszka@redhat.com \
--cc=users@rt2x00.serialmonkey.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).