Re: [PATCHv8 1/3] nl80211/cfg80211: add radar detection command/event

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2013-02-07 at 12:00 +0100, Simon Wunderlich wrote:

> > > + * @IEEE80211_DFS_USABLE: The channel can be used, but channel availability
> > > + *	check (CAC) must be performed before using it for AP or IBSS.
> > > + * @IEEE80211_DFS_UNAVAILABLE: A radar has been detected on this channel, it
> > > + *	is therefore marked as not available.
> > > + * @IEEE80211_DFS_AVAILABLE: The channel has been CAC checked and is available.
> > > + */
> > > +
> > > +enum nl80211_dfs_state {
> > > +	NL80211_DFS_USABLE	= 0,
> > 
> > I don't really see a reason for explicit values?
> > 
> 
> You've suggested explicit values yourself last time [1], or did I misunderstand?
> 
> [1] http://article.gmane.org/gmane.linux.kernel.wireless.general/103278
> "Should UNAVAILABLE be = 0, so that's the default?" (usable should be the default, btw)

Ah, no that was a misunderstanding then. Maybe it would've been clearer
if I'd said "Should UNAVAILABLE be first (=0), so that's the default?"
But if usable should be the default, that should be first. Anyway I
don't care much, we do rely on this enum behaviour a lot though so I
don't think we need explicit values.

> I've just moved this magic function from scan.c to core.h because I need it too.
> It appears another driver (drivers/net/wireless/ipw2x00) also implements this
> privately. We can suggest this patch for include/linux/jiffies.h if you prefer.

Maybe better do it afterwards, unless you don't mind waiting another few
months...? :)

johannes