From: Johannes Berg <johannes@sipsolutions.net>
To: Catalin Iacob <iacobcatalin@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Initialize rate_init member of struct rate_control_ops
Date: Mon, 11 Feb 2013 22:22:22 +0100 [thread overview]
Message-ID: <1360617742.8738.43.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1360617485-6194-1-git-send-email-iacobcatalin@gmail.com> (sfid-20130211_221826_368182_FF033C33)
On Mon, 2013-02-11 at 22:18 +0100, Catalin Iacob wrote:
> This partially reverts commit 44ba973699b831414c3f8eef68ee5a7fe1208a05.
>
> rate_control_rate_init assumes the rate_init member of
> struct rate_control_ops is not NULL therefore not initializing it leads to
> an oops as soon the driver succesfully associates to an AP.
>
> The removal of rate_update from 44ba973699b831414c3f8eef68ee5a7fe1208a05
> is ok because rate_update is checked for NULL before being
> called.
OTOH, if the driver supports HT then rate_update is critical to its
functioning properly, e.g. for SMPS updates.
johannes
next prev parent reply other threads:[~2013-02-11 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 21:18 [PATCH] rtlwifi: Initialize rate_init member of struct rate_control_ops Catalin Iacob
2013-02-11 21:22 ` Johannes Berg [this message]
2013-02-11 21:37 ` Larry Finger
2013-02-11 21:42 ` Johannes Berg
2013-02-11 21:48 ` Larry Finger
2013-02-11 21:58 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360617742.8738.43.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=iacobcatalin@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).