From: Joe Perches <joe@perches.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Avinash Patil <patila@marvell.com>,
Yogesh Powar <yogeshp@marvell.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH 1/2] mwifiex: coding style cleanup in bss parameter update
Date: Sat, 16 Feb 2013 00:28:37 -0800 [thread overview]
Message-ID: <1361003317.3444.4.camel@joe-AO722> (raw)
In-Reply-To: <1360993470-4828-2-git-send-email-bzhao@marvell.com>
On Fri, 2013-02-15 at 21:44 -0800, Bing Zhao wrote:
> From: Yogesh Ashok Powar <yogeshp@marvell.com>
> They all can make one line.
[]
> diff --git a/drivers/net/wireless/mwifiex/scan.c b/drivers/net/wireless/mwifiex/scan.c
[]
> @@ -1485,20 +1485,15 @@ static int mwifiex_update_curr_bss_params(struct mwifiex_private *priv,
> priv->curr_bss_params.bss_descriptor.bcn_wapi_ie = NULL;
> priv->curr_bss_params.bss_descriptor.wapi_offset = 0;
> priv->curr_bss_params.bss_descriptor.bcn_ht_cap = NULL;
> - priv->curr_bss_params.bss_descriptor.ht_cap_offset =
> - 0;
> + priv->curr_bss_params.bss_descriptor.ht_cap_offset = 0;
Another way to do this to reduce the visual noise it to
create a temporary
struct mwifiex_bssdescriptor *t = &priv->curr_bss_params.bss_descriptor;
and use
s/priv->curr_bss_params.bss_descriptor./t->/
next prev parent reply other threads:[~2013-02-16 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 5:44 [PATCH 0/2] mwifiex: support 11ac for 8897 Bing Zhao
2013-02-16 5:44 ` [PATCH 1/2] mwifiex: coding style cleanup in bss parameter update Bing Zhao
2013-02-16 8:28 ` Joe Perches [this message]
2013-02-19 23:17 ` Bing Zhao
2013-02-16 5:44 ` [PATCH 2/2] mwifiex: add 802.11AC support Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361003317.3444.4.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nishants@marvell.com \
--cc=patila@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox