From: Johannes Berg <johannes@sipsolutions.net>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: fix unaligned access to mac address
Date: Mon, 18 Feb 2013 11:10:20 +0100 [thread overview]
Message-ID: <1361182220.8555.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1361021140-19871-1-git-send-email-hauke@hauke-m.de> (sfid-20130216_142600_027602_45FAF12B)
On Sat, 2013-02-16 at 14:25 +0100, Hauke Mehrtens wrote:
> The mac address should be aligned to u16 to prevent an unaligned access
> in drivers/ssb/pci.c where it is casted to __be16.
>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> include/linux/ssb/ssb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ssb/ssb.h b/include/linux/ssb/ssb.h
> index 22958d6..457e8eb 100644
> --- a/include/linux/ssb/ssb.h
> +++ b/include/linux/ssb/ssb.h
> @@ -26,6 +26,7 @@ struct ssb_sprom_core_pwr_info {
>
> struct ssb_sprom {
> u8 revision;
> + u8 country_code; /* Country Code */
> u8 il0mac[6]; /* MAC address for 802.11b/g */
You should probably add __aligned(2) or so to them to avoid relying on
the struct layout only.
johannes
next prev parent reply other threads:[~2013-02-18 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 13:25 [PATCH] ssb: fix unaligned access to mac address Hauke Mehrtens
2013-02-18 10:10 ` Johannes Berg [this message]
2013-02-18 16:09 ` Rafał Miłecki
2013-02-20 17:31 ` Joe Perches
2013-02-20 17:56 ` Larry Finger
2013-02-20 18:29 ` Joe Perches
2013-02-20 19:17 ` Hauke Mehrtens
2013-02-20 20:11 ` Joe Perches
2013-02-21 3:34 ` Larry Finger
2013-03-09 23:02 ` Rafał Miłecki
2013-03-09 23:31 ` Larry Finger
2013-03-09 23:56 ` Larry Finger
2013-03-10 11:36 ` Rafał Miłecki
2013-03-10 17:35 ` Larry Finger
2013-03-10 20:57 ` Rafał Miłecki
2013-02-20 20:16 ` [PATCH 2/2] ssb: Convert ssb_printk to ssb_<level> Joe Perches
2013-02-20 19:07 ` [PATCH] ssb: fix unaligned access to mac address Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361182220.8555.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).