From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] mac80211: sync suspend and stop interface
Date: Wed, 20 Feb 2013 11:08:14 +0100 [thread overview]
Message-ID: <1361354894.8629.16.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130219164831.GB27140@redhat.com>
On Tue, 2013-02-19 at 17:48 +0100, Stanislaw Gruszka wrote:
> Is possible that we close interface while we are suspended, that
> results in warning like below (and some other similar):
>
> WARNING: at net/mac80211/driver-ops.h:12 ieee80211_do_stop+0x62e/0x670 [mac80211]()
> wlan0: Failed check-sdata-in-driver check, flags: 0x4
> Call Trace:
> [<ffffffff8105c9d6>] warn_slowpath_fmt+0x46/0x50
> [<ffffffffa045d46e>] ieee80211_do_stop+0x62e/0x670 [mac80211]
> [<ffffffffa045d4ca>] ieee80211_stop+0x1a/0x20 [mac80211]
> [<ffffffff815122ed>] __dev_close_many+0x7d/0xc0
> [<ffffffff81513af8>] dev_close_many+0x88/0x100
> [<ffffffff81513f2a>] dev_close+0x3a/0x50
> [<ffffffffa03c90ae>] cfg80211_rfkill_set_block+0x6e/0xa0 [cfg80211]
> [<ffffffffa03c9106>] cfg80211_rfkill_sync_work+0x26/0x30 [cfg80211]
>
> To fix check if interface was removed during suspend in
> ieee80211_do_stop() before perform any action that require operation
> on the interface.
This would also become simpler then because the key stuff for instance
wouldn't be necessary any more.
johannes
next prev parent reply other threads:[~2013-02-20 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 16:47 [RFC 1/2] mac80211: disconnect on suspend in managed mode Stanislaw Gruszka
2013-02-19 16:48 ` [RFC 2/2] mac80211: sync suspend and stop interface Stanislaw Gruszka
2013-02-20 10:08 ` Johannes Berg [this message]
2013-02-20 10:06 ` [RFC 1/2] mac80211: disconnect on suspend in managed mode Johannes Berg
2013-02-21 10:29 ` Stanislaw Gruszka
2013-02-22 20:31 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361354894.8629.16.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).