From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: fix unaligned access to mac address
Date: Wed, 20 Feb 2013 11:07:08 -0800 [thread overview]
Message-ID: <1361387228.3043.3.camel@joe-AO722> (raw)
In-Reply-To: <51250E6B.3030308@lwfinger.net>
On Wed, 2013-02-20 at 11:56 -0600, Larry Finger wrote:
> I like the looks of sprom_get_mac() over that ugly
> *(((__be16 *)out->il0mac)
> construct, but this patch breaks ssb.
> The resulting MAC address is all ones.
[]
> > @@ -539,10 +533,8 @@ static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
> > ARRAY_SIZE(out->core_pwr_info));
> >
> > /* extract the MAC address */
> > - for (i = 0; i < 3; i++) {
> > - v = in[SPOFF(SSB_SPROM8_IL0MAC) + i];
> > - *(((__be16 *)out->il0mac) + i) = cpu_to_be16(v);
> > - }
> > + sprom_get_mac(out->il0mac, &in[SSB_SPROM8_IL0MAC]);
Yup, I did a stupid.
This one should be:
sprom_get_mac(out->il0mac, &in[SPOFF(SSB_SPROM8_IL0MAC)]);
prev parent reply other threads:[~2013-02-20 19:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 13:25 [PATCH] ssb: fix unaligned access to mac address Hauke Mehrtens
2013-02-18 10:10 ` Johannes Berg
2013-02-18 16:09 ` Rafał Miłecki
2013-02-20 17:31 ` Joe Perches
2013-02-20 17:56 ` Larry Finger
2013-02-20 18:29 ` Joe Perches
2013-02-20 19:17 ` Hauke Mehrtens
2013-02-20 20:11 ` Joe Perches
2013-02-21 3:34 ` Larry Finger
2013-03-09 23:02 ` Rafał Miłecki
2013-03-09 23:31 ` Larry Finger
2013-03-09 23:56 ` Larry Finger
2013-03-10 11:36 ` Rafał Miłecki
2013-03-10 17:35 ` Larry Finger
2013-03-10 20:57 ` Rafał Miłecki
2013-02-20 20:16 ` [PATCH 2/2] ssb: Convert ssb_printk to ssb_<level> Joe Perches
2013-02-20 19:07 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361387228.3043.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).