From: Johannes Berg <johannes@sipsolutions.net>
To: Piotr Haber <phaber@broadcom.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] [RFC] cfg80211: configuration of Bluetooth coexistence mode
Date: Fri, 22 Feb 2013 15:07:33 +0100 [thread overview]
Message-ID: <1361542053.3420.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <53E0CDA8188165468B8B837459C34CA901053EEA@SJEXCHMB15.corp.ad.broadcom.com>
On Fri, 2013-02-22 at 13:32 +0000, Piotr Haber wrote:
> > Apart from a few minor technical comments that I'll omit for now, I'm
> > not sure what value this really has? EAPOL can already be "protected" by
> > way of knowing when the station is marked authorized, and DHCP is pretty
> > tricky because it could take "forever", might not be there at all, etc.
> By "protect" I meant give Wifi a priority over BT so these time sensitive things
> can finish quicker/on first try, limiting the possibility of dropping packets because of BT
> using the medium.
I know :)
> This is supposed to be temporary and time limited, so if say DHCP finishes in the window
> we give it - great, if not the coexistence goes back to default behavior and Wifi traffic is
> treated as usual.
That's not even documented/implemented, the way I read the patch you'd
have to set it back manually.
> > What application would actually call this? I don't really see how it
> > could be integrated like that.
> For EAPOL wpa_supplicant might use it. For DHCP it could be used from enter/exit hooks
> via iw or some other utility able to send nl messages.
See that's the thing, I don't really see the point for EAPOL: you could
just as well start protecting when the association is done, and end it
when the station is marked authorized. That will have protected any
EAPOL (or other protocols for that matter) traffic.
Similarly, you could give it a certain timeout to protect DHCP traffic.
I guess the only thing that would seem necessary would be a notification
of "DHCP done" that would allow you to drop the protection right away.
> This feature is styled after Android one.
I know, I'm (vaguely) familiar with that.
> There a Wifi state machine tries to "protect" DHCP traffic.
Is there any *reason* for it though? Would it ever call it after the
connection is fully established?
To me this seems not very well thought out.
johannes
next prev parent reply other threads:[~2013-02-22 14:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 9:08 [RFC 0/2] control Bluetooth coexistence Piotr Haber
2013-02-22 9:08 ` [PATCH 1/2] [RFC] cfg80211: configuration of Bluetooth coexistence mode Piotr Haber
2013-02-22 11:52 ` Johannes Berg
2013-02-22 13:32 ` Piotr Haber
2013-02-22 14:07 ` Johannes Berg [this message]
2013-02-22 14:59 ` Piotr Haber
2013-02-22 9:08 ` [PATCH 2/2] brcmfmac: control BT coexistence parameters Piotr Haber
-- strict thread matches above, loose matches on Subject: below --
2013-02-22 16:59 [PATCH 1/2] [RFC] cfg80211: configuration of Bluetooth coexistence mode Arend Van Spriel
2013-02-22 20:28 ` Johannes Berg
2013-02-23 0:30 ` Adrian Chadd
2013-02-23 17:47 ` Arend Van Spriel
2013-02-24 9:12 ` Emmanuel Grumbach
2013-02-24 17:28 ` Johannes Berg
2013-02-25 5:08 ` Adrian Chadd
2013-02-25 5:54 ` Felix Fietkau
2013-02-25 10:11 ` Arend van Spriel
2013-02-25 10:25 ` Johannes Berg
2013-02-25 13:07 ` Felix Fietkau
2013-02-27 10:27 ` Dan Williams
2013-02-27 17:44 ` Arend van Spriel
2013-02-28 11:53 ` Piotr Haber
2013-02-27 18:45 ` Johannes Berg
2013-02-27 17:21 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361542053.3420.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=phaber@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).