From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org, Thomas Pedersen <thomas@cozybit.com>
Subject: Re: [PATCH 3/6] mac80211: cleanup generic suspend/resume procedures
Date: Tue, 26 Feb 2013 21:49:20 +0100 [thread overview]
Message-ID: <1361911760.8440.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1361793008-2857-3-git-send-email-sgruszka@redhat.com>
On Mon, 2013-02-25 at 12:50 +0100, Stanislaw Gruszka wrote:
> @@ -95,17 +75,10 @@ int __ieee80211_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wowlan)
> WARN_ON(err != 1);
> local->wowlan = false;
> } else {
Hmmm! The context here reminds me that it is possible to have WoWLAN
configured, but have the driver reject it and then suspend "normally".
Our driver seems to be the only one doing it (both dvm and mvm flavours)
and it does it only in case we aren't connected ...
However overall this patchset will break the functionality, if WoWLAN is
enabled but not possible we won't cleanly disconnect. This is a bit of a
problem, I guess we need to propagate this return value behaviour all
the way into cfg80211 where the cfg80211_leave() can then be called?
johannes
next prev parent reply other threads:[~2013-02-26 20:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 11:50 [PATCH 1/6] cfg80211: disconnect on suspend Stanislaw Gruszka
2013-02-25 11:50 ` [PATCH 2/6] mac80211: sync suspend and stop interface Stanislaw Gruszka
2013-02-26 20:44 ` Johannes Berg
2013-02-27 10:42 ` Stanislaw Gruszka
2013-02-27 10:46 ` Johannes Berg
2013-02-27 14:54 ` Stanislaw Gruszka
2013-03-08 14:26 ` Stanislaw Gruszka
2013-02-25 11:50 ` [PATCH 3/6] mac80211: cleanup generic suspend/resume procedures Stanislaw Gruszka
2013-02-26 20:49 ` Johannes Berg [this message]
2013-02-25 11:50 ` [PATCH 4/6] mac80211: cleanup suspend/resume on managed mode Stanislaw Gruszka
2013-02-25 11:50 ` [PATCH 5/6] mac80211: cleanup suspend/resume on ibss mode Stanislaw Gruszka
2013-02-25 11:50 ` [PATCH 6/6] mac80211: cleanup suspend/resume on mesh mode Stanislaw Gruszka
2013-02-26 20:41 ` [PATCH 1/6] cfg80211: disconnect on suspend Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361911760.8440.15.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).