From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] minstrel_ht: improve accuracy of throughput metric at high data rates
Date: Mon, 04 Mar 2013 16:06:17 +0100 [thread overview]
Message-ID: <1362409577.21028.13.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1362255614-30859-1-git-send-email-nbd@openwrt.org>
On Sat, 2013-03-02 at 21:20 +0100, Felix Fietkau wrote:
> At high data rates the average frame transmission durations are small
> enough for rounding errors to matter, sometimes causing minstrel to use
> slightly lower transmit rates than necessary.
> To fix this, change the unit of the duration value to nanoseconds
> instead of microseconds, and reorder the multiplications/divisions when
> calculating the throughput metric so that they don't overflow or
> truncate prematurely.
> At 2-stream HT40 this makes TCP throughput a bit more stable.
Applied all 3.
johannes
prev parent reply other threads:[~2013-03-04 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 20:20 [PATCH 1/3] minstrel_ht: improve accuracy of throughput metric at high data rates Felix Fietkau
2013-03-02 20:20 ` [PATCH 2/3] mac80211/minstrel_ht: improve max_prob_rate selection Felix Fietkau
2013-03-02 20:20 ` [PATCH 3/3] minstrel_ht: increase sampling frequency Felix Fietkau
2013-03-04 15:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362409577.21028.13.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).