From: Joe Perches <joe@perches.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath6kl-devel@qualcomm.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath6kl: print firmware capabilities
Date: Tue, 05 Mar 2013 10:06:34 -0800 [thread overview]
Message-ID: <1362506794.1759.2.camel@joe-AO722> (raw)
In-Reply-To: <20130305163842.32118.84598.stgit@localhost6.localdomain6>
On Tue, 2013-03-05 at 18:38 +0200, Kalle Valo wrote:
> Printin the firmware capabilities during the first firmware boot makes it easier to find out what
> features firmware supports.
[]
> diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c
[]
> +static void ath6kl_init_fw_capas(struct ath6kl *ar, char *buf, size_t buf_len)
> +{
[]
> + if (buf_len - len < 4) {
> + ath6kl_warn("firmware capability buffer too small!\n");
> + strncpy(buf, "<error>", buf_len);
4 is an odd size to use.
It seems weird to overwrite the known bits.
why not just add ...?
next prev parent reply other threads:[~2013-03-05 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 16:38 [PATCH] ath6kl: print firmware capabilities Kalle Valo
2013-03-05 18:06 ` Joe Perches [this message]
2013-03-05 18:19 ` Kalle Valo
2013-03-05 18:31 ` Marcel Holtmann
2013-03-05 18:35 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2013-03-06 6:56 Kalle Valo
2013-03-18 11:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362506794.1759.2.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox