linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mac80211/minstrel_ht: disable multiple consecutive sample attempts
@ 2013-03-05 13:20 Felix Fietkau
  2013-03-05 18:48 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Felix Fietkau @ 2013-03-05 13:20 UTC (permalink / raw)
  To: linux-wireless; +Cc: johannes

The last minstrel_ht changes increased the sampling frequency for
potentially useful rates to decrease the response time to rate
fluctuations. This caused an increase in sampling frequency that can
slightly reduce throughput, so this patch limits the sampling attempts
to one per rate instead of two.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
 net/mac80211/rc80211_minstrel_ht.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index da4ec73..aa59539 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -480,7 +480,7 @@ minstrel_ht_tx_status(void *priv, struct ieee80211_supported_band *sband,
 
 	if (!mi->sample_wait && !mi->sample_tries && mi->sample_count > 0) {
 		mi->sample_wait = 16 + 2 * MINSTREL_TRUNC(mi->avg_ampdu_len);
-		mi->sample_tries = 2;
+		mi->sample_tries = 1;
 		mi->sample_count--;
 	}
 
-- 
1.8.0.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211/minstrel_ht: disable multiple consecutive sample attempts
  2013-03-05 13:20 [PATCH] mac80211/minstrel_ht: disable multiple consecutive sample attempts Felix Fietkau
@ 2013-03-05 18:48 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2013-03-05 18:48 UTC (permalink / raw)
  To: Felix Fietkau; +Cc: linux-wireless

On Tue, 2013-03-05 at 14:20 +0100, Felix Fietkau wrote:
> The last minstrel_ht changes increased the sampling frequency for
> potentially useful rates to decrease the response time to rate
> fluctuations. This caused an increase in sampling frequency that can
> slightly reduce throughput, so this patch limits the sampling attempts
> to one per rate instead of two.

Applied.

johannes


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-05 18:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 13:20 [PATCH] mac80211/minstrel_ht: disable multiple consecutive sample attempts Felix Fietkau
2013-03-05 18:48 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).