Re: [PATCH 1/2] mac80211: some fixes for ieee80211_do_stop while suspend

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2013-03-11 at 18:01 +0100, Stanislaw Gruszka wrote:
> Is possible that we close interface while we are suspended, that
> can result warning like below (and some others similar):

> Patch try to avoid calling most of drv callbacks when stopping interface
> while suspended.

try :-)

> Some further work is probably needed to handle ROC, DFS, WDS and
> ieee80211_{add,del}_virtual_monitor . However patch should fix issues

Fixing either any of those would be pretty tricky, I think.

> in most common scenario, i.e. managed mode without any new futures.

I hope you're not into the stock market now ;-)


> -		ieee80211_configure_filter(local);
> +		/* configure filter latter (if not suspended) */

later

> -		mutex_unlock(&local->mtx);
> +		/* tell driver latter (if not suspended) */

later

> -		if (going_down)
> +		if (going_down && !local->suspended)
>  			drv_remove_interface(local, sdata);

I really wonder if there's not a better solution ... I'll think about it
a bit.

johannes