From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: linux-wireless@vger.kernel.org, emmanuel.grumbach@intel.com
Subject: Re: [PATCH 3.9] mac80211: always synchronize_net() during station removal
Date: Mon, 18 Mar 2013 20:03:56 +0100 [thread overview]
Message-ID: <1363633436.8260.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAB=NE6VTCdBzsQ7j7VgpbERUqYDuE-=9B=eoRa0rdSE7AiE7ew@mail.gmail.com> (sfid-20130315_192241_156682_BADF0063)
On Fri, 2013-03-15 at 11:22 -0700, Luis R. Rodriguez wrote:
> On Thu, Mar 7, 2013 at 2:22 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Wed, 2013-03-06 at 23:19 +0100, Johannes Berg wrote:
> >> From: Johannes Berg <johannes.berg@intel.com>
> >>
> >> If there are keys left during station removal, then a
> >> synchronize_net() will be done (for each key, I have a
> >> patch to address this for 3.10), otherwise it won't be
> >> done at all which causes issues because the station
> >> could be used for TX while it's being removed from the
> >> driver -- that might confuse the driver.
> >>
> >> Fix this by always doing synchronize_net() if no key
> >> was present any more.
> >
> > Applied.
>
> This applies to v3.8 as well, do you want it there too?
Dunno, I don't know of a bug that was triggered by this, I only know our
new driver might trigger bugs without this.
johannes
prev parent reply other threads:[~2013-03-18 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 22:19 [PATCH 3.9] mac80211: always synchronize_net() during station removal Johannes Berg
2013-03-07 10:22 ` Johannes Berg
2013-03-15 18:22 ` Luis R. Rodriguez
2013-03-18 19:03 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363633436.8260.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).