From: Johannes Berg <johannes@sipsolutions.net>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: Mahesh Palivela <maheshp@posedge.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Karl Beldan <karl.beldan@rivierawaves.com>
Subject: Re: [RFC V2 1/2] mac80211: Use a cfg80211_chan_def in ieee80211_hw_conf_chan
Date: Tue, 19 Mar 2013 19:27:56 +0100 [thread overview]
Message-ID: <1363717676.8336.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130319122836.GA26078@magnum.frso.rivierawaves.com> (sfid-20130319_133144_369883_B8D75C15)
On Tue, 2013-03-19 at 13:28 +0100, Karl Beldan wrote:
> > > + cfreq_off = local->csa_channel->center_freq -
> > > + local->_oper_chandef.chan->center_freq;
> > > +
> > > + local->_oper_chandef.center_freq1 += cfreq_off;
> > > + local->_oper_chandef.center_freq2 += cfreq_off;
> >
> > can't add cfreq_off to center_freq2. Add only in case of non-zero
> > center_freq2?
Yeah this is certainly not right ... anyway no driver supports 80+80
now, so no harm done, but anyway I don't really like any of this. We
really need to handle extended chanswitch ...
Maybe we should just disconnect entirely (like we do for chanctx today)
if we have a channel that's wider than 20 MHz, since we don't handle
chanswitch properly.
johannes
next prev parent reply other threads:[~2013-03-19 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 0:23 [RFC V2 0/2] Enable VHT for non chanctxes drivers Karl Beldan
2013-03-19 0:23 ` [RFC V2 1/2] mac80211: Use a cfg80211_chan_def in ieee80211_hw_conf_chan Karl Beldan
2013-03-19 11:47 ` Mahesh Palivela
2013-03-19 12:28 ` Karl Beldan
2013-03-19 18:27 ` Johannes Berg [this message]
2013-03-20 3:46 ` Mahesh Palivela
2013-03-20 10:53 ` Mahesh Palivela
2013-03-20 12:29 ` Karl Beldan
2013-03-21 11:19 ` Mahesh Palivela
2013-03-22 10:49 ` Karl Beldan
2013-03-22 10:55 ` Johannes Berg
2013-03-22 13:50 ` Karl Beldan
2013-03-22 14:12 ` Karl Beldan
2013-03-22 14:21 ` Johannes Berg
2013-03-19 0:23 ` [RFC V2 2/2] mac80211: Let drivers not supporting channel contexts use VHT Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363717676.8336.3.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=karl.beldan@gmail.com \
--cc=karl.beldan@rivierawaves.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maheshp@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).