Linux wireless drivers development
 help / color / mirror / Atom feed
From: Mahesh Palivela <maheshp@posedge.com>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Karl Beldan <karl.beldan@rivierawaves.com>
Subject: Re: [RFC V2 1/2] mac80211: Use a cfg80211_chan_def in ieee80211_hw_conf_chan
Date: Wed, 20 Mar 2013 09:16:16 +0530	[thread overview]
Message-ID: <1363751176.9344.1.camel@WLAN-SW-TEST-03> (raw)
In-Reply-To: <20130319122836.GA26078@magnum.frso.rivierawaves.com>

On Tue, 2013-03-19 at 13:28 +0100, Karl Beldan wrote:
> On Tue, Mar 19, 2013 at 05:17:06PM +0530, Mahesh Palivela wrote:
> > On Tue, 2013-03-19 at 01:23 +0100, Karl Beldan wrote:
> > > From: Karl Beldan <karl.beldan@rivierawaves.com>

> > > +	local->_oper_chandef.center_freq1 += cfreq_off;
> > > +	local->_oper_chandef.center_freq2 += cfreq_off;
> > 
> > can't add cfreq_off to center_freq2. Add only in case of non-zero
> > center_freq2?
> > 
> At first I was like "why ?", but I hadn't spotted the places where we
> only check for "center_freq2 != 0".
> 
> 
> Thanks Mahesh, Have you tested vht with this ? 

Not yet Karl. I will give it a try and update you.

Thanks,
Mahesh


  parent reply	other threads:[~2013-03-20  3:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19  0:23 [RFC V2 0/2] Enable VHT for non chanctxes drivers Karl Beldan
2013-03-19  0:23 ` [RFC V2 1/2] mac80211: Use a cfg80211_chan_def in ieee80211_hw_conf_chan Karl Beldan
2013-03-19 11:47   ` Mahesh Palivela
2013-03-19 12:28     ` Karl Beldan
2013-03-19 18:27       ` Johannes Berg
2013-03-20  3:46       ` Mahesh Palivela [this message]
2013-03-20 10:53         ` Mahesh Palivela
2013-03-20 12:29           ` Karl Beldan
2013-03-21 11:19             ` Mahesh Palivela
2013-03-22 10:49   ` Karl Beldan
2013-03-22 10:55   ` Johannes Berg
2013-03-22 13:50     ` Karl Beldan
2013-03-22 14:12       ` Karl Beldan
2013-03-22 14:21       ` Johannes Berg
2013-03-19  0:23 ` [RFC V2 2/2] mac80211: Let drivers not supporting channel contexts use VHT Karl Beldan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363751176.9344.1.camel@WLAN-SW-TEST-03 \
    --to=maheshp@posedge.com \
    --cc=johannes@sipsolutions.net \
    --cc=karl.beldan@gmail.com \
    --cc=karl.beldan@rivierawaves.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox