From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: hostap@lists.shmoo.com, linux-wireless@vger.kernel.org,
David Spinadel <dvdspndl@gmail.com>
Subject: Re: rcutree tree warning during P2P device support testing
Date: Thu, 21 Mar 2013 13:21:38 +0100 [thread overview]
Message-ID: <1363868498.8181.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <514AF761.7070607@broadcom.com>
On Thu, 2013-03-21 at 13:04 +0100, Arend van Spriel wrote:
> >>> The p2p device is already removed upon stopping wpa_supplicant through
> >>> .del_virtual_intf() callback. Took a quick peek in
> >>> net/mac80211/iface.c:ieee80211_if_remove() and wonder whether I should
> >>> do cfg80211_unregister_wdev() in that code path as well. Guess so, right?
> >>
> >> I think so, yes. Does the warning go away if you do? :)
> >
> > Not tested yet.
>
> That did the trick. Apparently, wpa_s/driver_nl80211 does not do a
> stop_p2p_device. That is triggered by cfg80211_unregister_wdev(). Should
> wpa_s do the stop_p2p_device before deleting it or is the current
> behaviour fine.
It's fine, the kernel has to be able to handle it anyway, but there's a
small bug in this area that I'm trying to fix now.
johannes
prev parent reply other threads:[~2013-03-21 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 14:53 rcutree tree warning during P2P device support testing Arend van Spriel
2013-03-20 15:08 ` Johannes Berg
2013-03-20 21:17 ` Arend van Spriel
2013-03-20 21:29 ` Johannes Berg
2013-03-20 21:46 ` Arend van Spriel
2013-03-20 21:55 ` Johannes Berg
2013-03-21 12:04 ` Arend van Spriel
2013-03-21 12:21 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363868498.8181.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=dvdspndl@gmail.com \
--cc=hostap@lists.shmoo.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).