From: Johannes Berg <johannes@sipsolutions.net>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Sam Leffler <sleffler@chromium.org>
Subject: Re: Radiotap injected rates
Date: Fri, 22 Mar 2013 14:32:05 +0100 [thread overview]
Message-ID: <1363959125.8238.49.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130322132716.GB29340@magnum.frso.rivierawaves.com> (sfid-20130322_143029_102909_B7BB5045)
On Fri, 2013-03-22 at 14:27 +0100, Karl Beldan wrote:
> > > And, oops typo, I meant :
> > >
> > > + !(info->flags & IEEE80211_TX_CTL_INJECTED && info->control.rates[0] != -1))
> > >
> > Well actually this won't work anyway because control.rates[] isn't
> > initialized to -1.
> >
> Of course we would set info->control.rates[0] to -1 by default in
> ieee80211_parse_tx_radiotap and set it to something else if we parse a
> IEEE80211_RADIOTAP_{RATE,MCS} (i.e what I was referring to in 1b).
That still wouldn't work though, there are other paths leading to point
you're looking at. You'd have to set it always, which would probably
work but is tricky to ensure at the right points.
johannes
next prev parent reply other threads:[~2013-03-22 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-17 21:55 Radiotap injected rates Karl Beldan
2013-03-18 19:26 ` Johannes Berg
2013-03-18 19:54 ` Karl Beldan
2013-03-22 12:24 ` Johannes Berg
2013-03-22 13:27 ` Karl Beldan
2013-03-22 13:32 ` Johannes Berg [this message]
2013-03-22 13:53 ` Karl Beldan
2013-03-22 14:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363959125.8238.49.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=karl.beldan@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sleffler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).