From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: some fixes for ieee80211_do_stop while suspend
Date: Fri, 22 Mar 2013 22:14:09 +0100 [thread overview]
Message-ID: <1363986849.8238.71.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130318093046.GA1458@redhat.com>
On Mon, 2013-03-18 at 10:30 +0100, Stanislaw Gruszka wrote:
> I thought about 2 solutions:
>
> 1) Do not drv_remove_interface() and drv_stop() on suspend. Need to
> check and possibly rewrite drivers to work with that, so this is not
> preferred solution for me.
Yeah, that's probably not feasible. Actually this is what happens with
WoWLAN today, but still. OTOH, it'd only have to be done for drivers
that even can hotplug :)
> 2) Add "if (local->started && !local->suspended) check in some drv_
> callbacks, IOW silently ignore callbacks when suspended. This looks
> as even worse hack than this patch.
Agree, that's not really a great idea either.
I was more thinking along the lines of seeing whether during suspend
it'd be possible to put the interface into a state where it's safe to
not do any more cleanups at all, and then just not really execute the
do_stop() at all if it's still in that suspended state. But that looks
equally difficult to do.
johannes
prev parent reply other threads:[~2013-03-22 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 17:01 [PATCH 1/2] mac80211: some fixes for ieee80211_do_stop while suspend Stanislaw Gruszka
2013-03-11 17:01 ` [PATCH 2/2] mac80211: fixes for virtual monitor add/remove on suspend Stanislaw Gruszka
2013-03-11 17:07 ` Stanislaw Gruszka
2013-03-12 10:32 ` [PATCH 2/2 v2] " Stanislaw Gruszka
2013-03-15 15:44 ` [PATCH 1/2] mac80211: some fixes for ieee80211_do_stop while suspend Johannes Berg
2013-03-18 9:30 ` Stanislaw Gruszka
2013-03-22 21:14 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363986849.8238.71.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).