From: Johannes Berg <johannes@sipsolutions.net>
To: Jonas Gorski <jogo@openwrt.org>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Yogesh Ashok Powar <yogeshp@marvell.com>
Subject: Re: [PATCH] mwl8k: always apply configuration even when device is idle
Date: Mon, 25 Mar 2013 16:49:57 +0100 [thread overview]
Message-ID: <1364226597.17540.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1364225994-19375-1-git-send-email-jogo@openwrt.org> (sfid-20130325_164018_264244_A96E8CFF)
On Mon, 2013-03-25 at 16:39 +0100, Jonas Gorski wrote:
> Fix settings not being applied when the device is idle and the firmware
> gets reloaded (because of changing from STA to AP mode). This caused
> the device using the wrong channel (and likely band), e.g. a 5 GHz only
> card still defaulted to channel 6 in the 2.4 GHz band when left
> unconfigured.
>
> This issue was always present, but only made visible with "mwl8k: Do not
> call mwl8k_cmd_set_rf_channel unconditionally" (0f4316b9), since before
> that the channel was (re-)configured at the next _config call even when
> it did not change from the mac80211 perspective.
I'm changing mac80211 back to unset idle first and then set the channel,
if that helps ... ath9k_htc was also broken by the change.
johannes
next prev parent reply other threads:[~2013-03-25 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 15:39 [PATCH] mwl8k: always apply configuration even when device is idle Jonas Gorski
2013-03-25 15:49 ` Johannes Berg [this message]
2013-03-25 16:15 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364226597.17540.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jogo@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nishants@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox