Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: vivekanandah@posedge.com
Cc: linux-wireless@vger.kernel.org, nbd@openwrt.org
Subject: Re: RFC: SMPS for AP mode
Date: Tue, 09 Apr 2013 12:19:10 +0200	[thread overview]
Message-ID: <1365502750.8465.30.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <021a065e3ab402466e8049b2f4cd3fdd@posedge.com>

Hi,

> based on the discussion, i have come out with an RFC for SMPS support 
> for AP in minstrel_ht. kindly see the explanation below and indicate to 
> me, if this okay or any changes are required?

Code talks ;-)

> RFC To send out RTS for AP connected to a dynamic SMPS station
> 
> This code change addresses the AP requirement of sending out a
> RTS frame when dynamic SMPS is enabled at the station
> 
> the minstrel_ht rate module needs to provide the lower driver layer
> an indication of enabling RTS frame transmission for an AP connected
> to a dynamic SMPS station.

It really just needs to set the RTS flag on the frames.

> the SMPS state of the station is stored in the ieee80211_sta 
> structure's ht_cap variable.

No, not any more.

> the minstrel_ht_get_rate function can be modified to check if the 
> station is a dynamic SMPS
> station and a new flag can be incorporated for the ieee80211_tx_info 
> flags (e.g. IEEE80211_TX_CTL_SMPS_SET_RTS)
> that indicates to the lower layer that the station is a dynamic SMPS 
> enabled station.
> 
> the lower AP driver can then enable RTS before the first frame 
> transmission to the station by checking for the above flag.

Sounds about right.

johannes


  reply	other threads:[~2013-04-09 10:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03  7:35 question on SMPS for AP vivekanandah
2013-04-03  8:05 ` Johannes Berg
2013-04-03  8:36   ` vivekanandah
2013-04-03  8:46     ` Johannes Berg
2013-04-04  6:27       ` RFC: SMPS for AP mode vivekanandah
2013-04-09 10:19         ` Johannes Berg [this message]
2013-04-09 15:55           ` Naveenraj Subramanian
     [not found]   ` <CAGXE3d_Up9BwfR3gC4uDh_4PNfAaMCME7dVeRnNrpmvc70ZALQ@mail.gmail.com>
2013-04-03  8:37     ` question on SMPS for AP vivekanandah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365502750.8465.30.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    --cc=vivekanandah@posedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox