From: Johannes Berg <johannes@sipsolutions.net>
To: Antonio Quartulli <antonio@open-mesh.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] cfg80211: add get_max_tp() API
Date: Tue, 09 Apr 2013 12:25:08 +0200 [thread overview]
Message-ID: <1365503108.8465.34.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130406073309.GB14463@open-mesh.com>
> But the reported_rate field would just contain the index of the selected rate,
> not the throughput. As far as I can tell the latter is an RC private information
> (it not exported anywhere outside of the RC algorithm) and that is why I made
> this API which would directly talk to minstrel and get this value.
Actually it would contain the entire rate configuration.
Anyway my concern is that you're adding something that's rather minstrel
specific. It's not really usable by any other algorithm, you're
reporting minstrel's estimation of the throughput. If you report the
current "best" rate, that'll probably get you pretty much the same
behaviour overall, but be more portable to other algorithms I think.
johannes
next prev parent reply other threads:[~2013-04-09 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 19:57 [PATCH 1/3] cfg80211: add get_max_tp() API Antonio Quartulli
2013-04-04 19:57 ` [PATCH 2/3] mac80211: add rate_control_ops::get_max_tp() and implement it Antonio Quartulli
2013-04-04 19:57 ` [PATCH 3/3] mac80211: implement cfg80211_ops::get_max_tp() API Antonio Quartulli
2013-04-05 8:21 ` [PATCH 1/3] cfg80211: add get_max_tp() API Helmut Schaa
2013-04-05 8:39 ` Antonio Quartulli
2013-04-05 13:20 ` Johannes Berg
2013-04-06 7:33 ` Antonio Quartulli
2013-04-09 10:25 ` Johannes Berg [this message]
2013-04-09 11:34 ` Antonio Quartulli
2013-04-11 9:56 ` Johannes Berg
2013-04-11 9:57 ` Johannes Berg
2013-04-12 14:10 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365503108.8465.34.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=antonio@open-mesh.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).