From: Johannes Berg <johannes@sipsolutions.net>
To: vivekanandah@posedge.com
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [Patch] mac80211: SMPS for AP Mode
Date: Thu, 11 Apr 2013 10:22:29 +0200 [thread overview]
Message-ID: <1365668549.8272.9.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <403b23c5df64cb4e0d6ffbabb7ca804f@posedge.com>
Hi Vivek,
No worries.
> i have outlined three requirements based on my understanding for SMPS
> code and have also incorporated a code snippet. if you are okay with the
> code snippet, i will provide a patch for the same.
>
> 1) check if the receiving station has Dynamic SMPS on
> 2) check if the current MCS rate is greater than a single stream rate
> for the first rate
Note that MCS 32 is also single-stream. I'm not sure any driver supports
it, and I think minstrel_ht probably also doesn't support it, so I guess
you don't have to worry about it, but you may want to check.
> 3) if conditions 1 and 2 are true, set the RTS_CTS flag for the first
> rate that will be attempted to be transmitted
No, you don't just need the first rate, you need any rate that's
multi-stream. Otherwise a retransmission at a lower rate would never
work.
johannes
next prev parent reply other threads:[~2013-04-11 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 10:42 [Patch] mac80211: SMPS for AP Mode Vivekananda Holla
2013-04-10 11:18 ` Johannes Berg
2013-04-11 5:21 ` vivekanandah
2013-04-11 8:22 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-04-10 8:54 Vivekananda Holla
2013-04-10 8:55 ` Johannes Berg
2013-04-10 9:35 ` Vivekananda Holla
2013-04-10 9:46 ` Johannes Berg
2013-04-10 9:47 ` Johannes Berg
2013-04-10 9:55 ` Vivekananda Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365668549.8272.9.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vivekanandah@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).