From: Johannes Berg <johannes@sipsolutions.net>
To: Vivekananda Holla <vivekanandah@posedge.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [Patch] mac80211: add rts-cts for dynamic SMPS stations
Date: Mon, 15 Apr 2013 11:24:04 +0200 [thread overview]
Message-ID: <1366017844.8361.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <516B9F21.2080304@posedge.com>
Vivek,
Please work with some of your colleagues at posedge to submit a proper
patch. This is formatted completely wrongly in many ways.
> + if (dyn_smps) {
> + if ((info->control.rates[i].idx > 7) &&
> + (info->control.rates[i].idx != 32))
This is also completely wrong. (hint, there are non-HT bitrates still)
johannes
next prev parent reply other threads:[~2013-04-15 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 6:33 [Patch] mac80211: add rts-cts for dynamic SMPS stations Vivekananda Holla
2013-04-15 9:24 ` Johannes Berg [this message]
2013-04-15 10:43 ` Vivekananda Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366017844.8361.7.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vivekanandah@posedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).