From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/5] mac80211: fix and optimize MCS mask handling
Date: Mon, 15 Apr 2013 15:38:44 +0200 [thread overview]
Message-ID: <1366033124.8361.22.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1365890626-86895-1-git-send-email-nbd@openwrt.org>
> for (i = 0; i < IEEE80211_NUM_BANDS; i++) {
> + struct ieee80211_supported_band *sband = wiphy->bands[i];
> + int j;
> +
> sdata->rc_rateidx_mask[i] = mask->control[i].legacy;
> memcpy(sdata->rc_rateidx_mcs_mask[i], mask->control[i].mcs,
> sizeof(mask->control[i].mcs));
> +
> + sdata->rc_has_mcs_mask[i] = false;
> + if (!sband)
> + continue;
> +
> + for (j = 0; j < IEEE80211_HT_MCS_MASK_LEN; j++)
I think I'd kinda prefer extra braces, but hey, I'd change that myself,
but there's another question:
> + if (~sdata->rc_rateidx_mcs_mask[i][j]) {
That ~ seems a bit odd to me, any reason you didn't just use ! ?
johannes
next prev parent reply other threads:[~2013-04-15 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 22:03 [PATCH 1/5] mac80211: fix and optimize MCS mask handling Felix Fietkau
2013-04-13 22:03 ` [PATCH 2/5] mac80211: fix CTS protection handling Felix Fietkau
2013-04-13 22:03 ` [PATCH 3/5] mac80211: improve the rate control API Felix Fietkau
2013-04-13 22:03 ` [PATCH 4/5] mac80211/minstrel_ht: use the new " Felix Fietkau
2013-04-13 22:03 ` [PATCH 5/5] mac80211/minstrel: " Felix Fietkau
2013-04-15 13:44 ` [PATCH 3/5] mac80211: improve the " Johannes Berg
2013-04-15 14:27 ` Felix Fietkau
2013-04-16 10:03 ` Karl Beldan
2013-04-16 10:44 ` Felix Fietkau
2013-04-15 13:40 ` [PATCH 2/5] mac80211: fix CTS protection handling Johannes Berg
2013-04-15 14:24 ` Felix Fietkau
2013-04-15 13:38 ` Johannes Berg [this message]
2013-04-15 14:19 ` [PATCH 1/5] mac80211: fix and optimize MCS mask handling Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366033124.8361.22.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).