Re: [PATCH v2 2/2] mac80211: add support for per-chain signal strength reporting

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2013-04-22 at 16:29 +0200, Felix Fietkau wrote:
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
>  include/net/mac80211.h  |  5 +++++
>  net/mac80211/cfg.c      | 13 ++++++++++++-
>  net/mac80211/rx.c       | 14 ++++++++++++++
>  net/mac80211/sta_info.c |  2 ++
>  net/mac80211/sta_info.h |  5 +++++
>  5 files changed, 38 insertions(+), 1 deletion(-)
> 
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index 4ecff78..aeb4a5c 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -848,6 +848,9 @@ enum mac80211_rx_flags {
>   * @signal: signal strength when receiving this frame, either in dBm, in dB or
>   *	unspecified depending on the hardware capabilities flags
>   *	@IEEE80211_HW_SIGNAL_*
> + * @chains: bitmask of receive chains for which separate signal strength
> + *	values were filled.
> + * @chain_signal: per-chain signal strength, same format as @signal

Oops, sorry, I should've looked at this patch before ... This isn't
right, @signal can be in "dB" or "unspec" units, but @chain_signal is
required to be dBm. If you want, I'll edit the patch to just say that it
must only be provided in dBm?

johannes