From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@adurom.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC v2] cfg80211: Android P2P-Device workaround
Date: Wed, 24 Apr 2013 12:44:54 +0200 [thread overview]
Message-ID: <1366800294.11111.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <87mwso5jbx.fsf@purkki.adurom.net>
On Wed, 2013-04-24 at 13:11 +0300, Kalle Valo wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > +#ifndef CONFIG_CFG80211_ANDROID_P2P_HACK
> > if (WARN_ON(wdev->netdev))
> > return;
> > +#endif
>
> With my favorite kernel macro, config_enabled(), you could get rid of
> quite a lot of the ugly ifdefs.
Yeah, but as long as this isn't going upstream I don't really want to
though since then it touches the code and is less obvious. Anyway we'll
see.
johannes
next prev parent reply other threads:[~2013-04-24 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 8:26 [RFC v2] cfg80211: Android P2P-Device workaround Johannes Berg
2013-04-24 10:11 ` Kalle Valo
2013-04-24 10:44 ` Johannes Berg [this message]
2013-04-24 10:52 ` Kalle Valo
2013-04-24 19:16 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366800294.11111.7.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).