From: Johannes Berg <johannes@sipsolutions.net>
To: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Cc: linux-wireless@vger.kernel.org,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [PATCH] mac80211 allow HT override of ampdu factor/density
Date: Fri, 26 Apr 2013 16:14:53 +0200 [thread overview]
Message-ID: <1366985693.8295.12.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1366985513.8295.10.camel@jlt4.sipsolutions.net> (sfid-20130426_161201_039179_76312B45)
On Fri, 2013-04-26 at 16:11 +0200, Johannes Berg wrote:
> On Tue, 2013-04-09 at 17:49 +0200, Simon Wunderlich wrote:
> > In the current implementation, amdpu changes are applied to own_cap,
> > but never actually applied to the stations ht settings, leaving these
> > overrides without effect.
> >
> > Fix this by using the minimum (factor) or maximum (density) of the
> > respective remote and own ampdu values.
>
> Applied, sorry I missed this.
No, hold on, I take that back.
This patch is wrong, there's no relation between our own capabilities
and the peer station's, so the current behaviour is correct. Maybe the
overrides are not properly applied in ieee80211_apply_htcap_overrides()
and then that doesn't take effect in ieee80211_add_ht_ie(), but clearly
that'd require a different change.
johannes
prev parent reply other threads:[~2013-04-26 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 15:49 [PATCH] mac80211 allow HT override of ampdu factor/density Simon Wunderlich
2013-04-26 14:11 ` Johannes Berg
2013-04-26 14:14 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366985693.8295.12.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).