From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: mac80211: 3.9.0+: Invalid WDS/flush state and non-connecting station.
Date: Fri, 10 May 2013 23:25:28 +0200 [thread overview]
Message-ID: <1368221128.8390.47.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <518D64E6.8000102@candelatech.com>
On Fri, 2013-05-10 at 14:21 -0700, Ben Greear wrote:
> void cfg80211_mlme_down(struct cfg80211_registered_device *rdev,
> struct net_device *dev)
> {
> struct wireless_dev *wdev = dev->ieee80211_ptr;
> struct cfg80211_deauth_request req;
> u8 bssid[ETH_ALEN];
>
> ASSERT_WDEV_LOCK(wdev);
>
> printk("mlme_down: %s: type: %i sme_state: %i current-bss: %p\n",
> dev->name, (int)(wdev->iftype), (int)(wdev->sme_state),
> wdev->current_bss);
>
> I see this printout for the stuck station (this is dmesg | grep sta74,
> so it skips errors about other interfaces that are also hung).
>
> I am guessing we should never be calling mlme_down with state
> of CFG80211_SME_CONNECTED when bss is NULL?
We should _never_ be in a state where current_bss is NULL but the state
is != IDLE. The question I can't seem to find an answer for is how we
got into that state, that we're in the state in down() is really less
interesting.
Since you seem to be able to reproduce this, maybe it'd help to mark all
state transitions and current_bss assignments, and then backtrack them
after the fact.
johannes
next prev parent reply other threads:[~2013-05-10 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 19:50 mac80211: 3.9.0+: Invalid WDS/flush state and non-connecting station Ben Greear
2013-05-02 20:24 ` Johannes Berg
2013-05-02 20:45 ` Ben Greear
2013-05-08 16:18 ` Ben Greear
2013-05-08 17:58 ` Johannes Berg
2013-05-08 18:14 ` Ben Greear
2013-05-10 21:21 ` Ben Greear
2013-05-10 21:25 ` Johannes Berg [this message]
2013-05-10 21:33 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368221128.8390.47.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).