From: Johannes Berg <johannes@sipsolutions.net>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] mac80211: add STBC flag for radiotap
Date: Wed, 22 May 2013 21:24:34 +0200 [thread overview]
Message-ID: <1369250674.8207.26.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1368949136-6079-2-git-send-email-linux@rempel-privat.de> (sfid-20130519_093926_441072_B1D2886A)
On Sun, 2013-05-19 at 09:38 +0200, Oleksij Rempel wrote:
> + * @RX_FLAG_STBC_MASK: STBC 2 bit bitmask. 1 - Nss=1, 2 - Nss=2, 3 - Nss=3
> + RX_FLAG_STBC_MASK = BIT(26) | BIT(27),
> @@ -258,6 +258,7 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local *local,
> pos += 2;
>
> if (status->flag & RX_FLAG_HT) {
> + unsigned int stbc = status->flag & RX_FLAG_STBC_MASK;
> rthdr->it_present |= cpu_to_le32(1 << IEEE80211_RADIOTAP_MCS);
> *pos++ = local->hw.radiotap_mcs_details;
> *pos = 0;
> @@ -267,6 +268,9 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local *local,
> *pos |= IEEE80211_RADIOTAP_MCS_BW_40;
> if (status->flag & RX_FLAG_HT_GF)
> *pos |= IEEE80211_RADIOTAP_MCS_FMT_GF;
> + if (stbc)
> + *pos |= (stbc >> RX_FLAG_STBC_SHIFT)
> + << IEEE80211_RADIOTAP_MCS_STBC_SHIFT;
> pos++;
> *pos++ = status->rate_idx;
Here you forgot the "HAVE" bit.
> - IEEE80211_RADIOTAP_MCS_HAVE_BW;
> + IEEE80211_RADIOTAP_MCS_HAVE_BW |
> + IEEE80211_RADIOTAP_MCS_HAVE_STBC;
And here it's completely bogus.
johannes
next prev parent reply other threads:[~2013-05-22 19:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 7:38 [PATCH 0/3] Work on STBC Rx monitoring Oleksij Rempel
2013-05-19 7:38 ` [PATCH 1/3] mac80211: add STBC flag for radiotap Oleksij Rempel
2013-05-22 19:24 ` Johannes Berg [this message]
2013-05-23 7:17 ` [PATCH v2 " Oleksij Rempel
2013-05-23 12:24 ` Johannes Berg
2013-05-23 14:11 ` [PATCH v3 " Oleksij Rempel
2013-05-23 21:33 ` Johannes Berg
2013-05-24 10:05 ` [PATCH v4 " Oleksij Rempel
2013-05-24 10:08 ` Johannes Berg
2013-05-24 10:11 ` Oleksij Rempel
2013-05-19 7:38 ` [PATCH 2/3] ath9k: remove useless flag conversation Oleksij Rempel
2013-05-19 7:38 ` [PATCH 3/3] ath9k: check for Rx-STBC flag and pass it to ieee80211 Oleksij Rempel
2013-05-24 10:18 ` [PATCH 0/2] ath9k: STBC Rx monitoring Oleksij Rempel
2013-05-24 10:18 ` [PATCH 1/2] ath9k: remove useless flag conversation Oleksij Rempel
2013-05-24 10:18 ` [PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211 Oleksij Rempel
2013-05-24 10:29 ` Johannes Berg
2013-05-24 10:32 ` Oleksij Rempel
2013-05-24 11:35 ` Oleksij Rempel
2013-05-24 18:30 ` [PATCH v4 " Oleksij Rempel
2013-05-30 8:57 ` [PATCH 0/3] Work on STBC Rx monitoring Oleksij Rempel
-- strict thread matches above, loose matches on Subject: below --
2013-05-02 20:44 Standardisation - adding 2 bit STBC and Ness to MCS Johannes Berg
2013-05-03 19:53 ` Patches for STBC Standartisation Oleksij Rempel
2013-05-03 19:53 ` [PATCH 1/3] mac80211: add STBC flag for radiotap Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369250674.8207.26.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).