From: Johannes Berg <johannes@sipsolutions.net>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 1/3] mac80211: add STBC flag for radiotap
Date: Thu, 23 May 2013 23:33:59 +0200 [thread overview]
Message-ID: <1369344839.12002.85.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1369318279-13768-1-git-send-email-linux@rempel-privat.de> (sfid-20130523_161134_412220_27EEFD62)
On Thu, 2013-05-23 at 16:11 +0200, Oleksij Rempel wrote:
> - *pos++ = local->hw.radiotap_mcs_details;
> +
> + /* MCS known field */
> + *pos = local->hw.radiotap_mcs_details;
> + if (stbc)
> + *pos |= IEEE80211_RADIOTAP_MCS_HAVE_STBC;
I think you shouldn't make this change, and the driver should include
the HAVE_STBC flag in the hw.radiotap_mcs_details. I actually thought of
this approach as well, but now just realized that this means that if the
driver _knows_ that a certain frame was received w/o STBC, this
knowledge cannot be transferred to the user, which would be a loss of
information.
> + if (stbc)
> + *pos |= (stbc >> RX_FLAG_STBC_SHIFT)
> + <<
> IEEE80211_RADIOTAP_MCS_STBC_SHIFT;
No need for the if() here, OR'ing in 0 doesn't do anything.
johannes
next prev parent reply other threads:[~2013-05-23 21:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 7:38 [PATCH 0/3] Work on STBC Rx monitoring Oleksij Rempel
2013-05-19 7:38 ` [PATCH 1/3] mac80211: add STBC flag for radiotap Oleksij Rempel
2013-05-22 19:24 ` Johannes Berg
2013-05-23 7:17 ` [PATCH v2 " Oleksij Rempel
2013-05-23 12:24 ` Johannes Berg
2013-05-23 14:11 ` [PATCH v3 " Oleksij Rempel
2013-05-23 21:33 ` Johannes Berg [this message]
2013-05-24 10:05 ` [PATCH v4 " Oleksij Rempel
2013-05-24 10:08 ` Johannes Berg
2013-05-24 10:11 ` Oleksij Rempel
2013-05-19 7:38 ` [PATCH 2/3] ath9k: remove useless flag conversation Oleksij Rempel
2013-05-19 7:38 ` [PATCH 3/3] ath9k: check for Rx-STBC flag and pass it to ieee80211 Oleksij Rempel
2013-05-24 10:18 ` [PATCH 0/2] ath9k: STBC Rx monitoring Oleksij Rempel
2013-05-24 10:18 ` [PATCH 1/2] ath9k: remove useless flag conversation Oleksij Rempel
2013-05-24 10:18 ` [PATCH 2/2] ath9k: check for Rx-STBC flag and pass it to ieee80211 Oleksij Rempel
2013-05-24 10:29 ` Johannes Berg
2013-05-24 10:32 ` Oleksij Rempel
2013-05-24 11:35 ` Oleksij Rempel
2013-05-24 18:30 ` [PATCH v4 " Oleksij Rempel
2013-05-30 8:57 ` [PATCH 0/3] Work on STBC Rx monitoring Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369344839.12002.85.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@rempel-privat.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).