From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
Luciano Coelho <coelho@ti.com>,
Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: [PATCH v2 1/2] cfg80211/nl80211: rename packet pattern related structures and enums
Date: Fri, 24 May 2013 22:10:17 +0200 [thread overview]
Message-ID: <1369426217.8290.22.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1369344908-11184-1-git-send-email-bzhao@marvell.com>
On Thu, 2013-05-23 at 14:35 -0700, Bing Zhao wrote:
> -enum nl80211_wowlan_packet_pattern_attr {
I think you missed a #define for this?
> +/* only for backward compatibility */
> +#define __NL80211_WOWLAN_PKTPAT_INVALID __NL80211_INVALID,
that , at the end looks like a copy/paste error, but in fact shouldn't
it be "__NL80211_PKTPAT_INVALID" anyway?
> * that is part of %NL80211_ATTR_WOWLAN_TRIGGERS_SUPPORTED in the
> * capability information given by the kernel to userspace.
Should this be updated?
johannes
next prev parent reply other threads:[~2013-05-24 20:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 21:35 [PATCH v2 1/2] cfg80211/nl80211: rename packet pattern related structures and enums Bing Zhao
2013-05-23 21:35 ` [PATCH v2 2/2] cfg80211/nl80211: Add packet coalesce support Bing Zhao
2013-05-24 20:22 ` Johannes Berg
2013-05-28 16:24 ` Amitkumar Karwar
2013-06-03 15:28 ` Johannes Berg
2013-06-03 16:47 ` Amitkumar Karwar
2013-06-10 17:52 ` Bing Zhao
2013-06-11 11:32 ` Johannes Berg
2013-06-12 19:20 ` Bing Zhao
2013-05-24 20:10 ` Johannes Berg [this message]
2013-05-28 16:21 ` [PATCH v2 1/2] cfg80211/nl80211: rename packet pattern related structures and enums Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369426217.8290.22.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=coelho@ti.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=senthilb@qca.qualcomm.com \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox