From: Johannes Berg <johannes@sipsolutions.net>
To: Ashok Nagarajan <ashok@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
devel@lists.open80211s.org
Subject: Re: [PATCH 3/3] {nl,mac,cfg}80211: Allow user to configure basic rates for mesh
Date: Fri, 24 May 2013 23:59:00 +0200 [thread overview]
Message-ID: <1369432740.13623.12.camel@johannes> (raw)
In-Reply-To: <1368233453-10581-3-git-send-email-ashok@cozybit.com> (sfid-20130511_025109_843981_AF868450)
Sorry for leaving this open for so long. I think it didn't hurt since
the merge window was open anyway.
> + * @basic_rates: per-band bitmap of basic rates to use when creating the mesh
Does per-band really make sense? The mesh channel is also determined at
join time.
> static int nl80211_join_ibss(struct sk_buff *skb, struct genl_info *info)
> {
> struct cfg80211_registered_device *rdev = info->user_ptr[0];
> @@ -7460,6 +7487,22 @@ static int nl80211_join_mesh(struct sk_buff *skb, struct genl_info *info)
> nla_get_u32(info->attrs[NL80211_ATTR_MCAST_RATE])))
> return -EINVAL;
>
> + if (info->attrs[NL80211_ATTR_BSS_BASIC_RATES]) {
I think you should consider allowing this attribute only if the channel
is also specified (NL80211_ATTR_WIPHY_FREQ, parsed below), and not make
it nested with rates for both bands but just the selected band.
johannes
next prev parent reply other threads:[~2013-05-24 21:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 0:50 [PATCH 1/3] {cfg,mac}80211: move mandatory rates calculation to cfg80211 Ashok Nagarajan
2013-05-11 0:50 ` [PATCH 2/3] cfg80211: Allow ieee80211g mandatory rate sets in 2.4GHz band Ashok Nagarajan
2013-05-13 9:42 ` Johannes Berg
2013-05-13 17:13 ` Ashok Nagarajan
2013-05-13 17:18 ` Johannes Berg
2013-05-13 17:20 ` Ashok Nagarajan
2013-05-11 0:50 ` [PATCH 3/3] {nl,mac,cfg}80211: Allow user to configure basic rates for mesh Ashok Nagarajan
2013-05-24 21:59 ` Johannes Berg [this message]
2013-05-24 23:13 ` Ashok Nagarajan
2013-05-25 8:20 ` Johannes Berg
2013-05-30 16:47 ` Ashok Nagarajan
2013-05-24 21:56 ` [PATCH 1/3] {cfg,mac}80211: move mandatory rates calculation to cfg80211 Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369432740.13623.12.camel@johannes \
--to=johannes@sipsolutions.net \
--cc=ashok@cozybit.com \
--cc=devel@lists.open80211s.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox