Re: P2P Device support: how to deal with p2p_no_group_iface option

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2013-05-27 at 16:03 +0200, Arend van Spriel wrote:
> On 05/27/2013 03:59 PM, Johannes Berg wrote:
> > On Mon, 2013-05-27 at 15:56 +0200, Arend van Spriel wrote:
> >
> >>> I don't think I'd do either of those. Not creating P2P_DEVICE will
> >>> simply not work with drivers expecting it, and changing iftype to/from
> >>> P2P-Device isn't supported since it would delete/create the netdev.
> >>
> >> So should we check that in cfg80211 upon wiphy_register().
> >
> > Check what?
> 
> Check that the interface combinations contain a iface limit with only 
> P2P_DEVICE:
> 
> 	{
> 		.max = 1,
> 		.types = BIT(NL80211_IFTYPE_P2P_DEVICE)
> 	}

We have that, right?

wiphy_verify_combinations:
                        /* Only a single P2P_DEVICE can be allowed */
                        if (WARN_ON(types &
BIT(NL80211_IFTYPE_P2P_DEVICE) &&
                                    c->limits[j].max > 1))
                                return -EINVAL;

johannes