Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"Hante Meuleman" <meuleman@broadcom.com>,
	"Arend van Spriel" <arend@broadcom.com>
Subject: [PATCH for 3.10 7/7] brcmfmac: Disable powersave mode for P2P link.
Date: Mon, 27 May 2013 21:09:59 +0200	[thread overview]
Message-ID: <1369681799-3163-8-git-send-email-arend@broadcom.com> (raw)
In-Reply-To: <1369681799-3163-1-git-send-email-arend@broadcom.com>

From: Hante Meuleman <meuleman@broadcom.com>

For p2p client mode powersave mode should be kept disabled. It is
working but inefficient. In general p2p links do no benefit from this
mode, because these links are setup temporarily to transfer data.

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
---
 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
index 6a87178..301e572 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
@@ -2248,6 +2248,11 @@ brcmf_cfg80211_set_power_mgmt(struct wiphy *wiphy, struct net_device *ndev,
 	}
 
 	pm = enabled ? PM_FAST : PM_OFF;
+	/* Do not enable the power save after assoc if it is a p2p interface */
+	if (ifp->vif->wdev.iftype == NL80211_IFTYPE_P2P_CLIENT) {
+		brcmf_dbg(INFO, "Do not enable power save for P2P clients\n");
+		pm = PM_OFF;
+	}
 	brcmf_dbg(INFO, "power save %s\n", (pm ? "enabled" : "disabled"));
 
 	err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_SET_PM, pm);
-- 
1.7.10.4



      parent reply	other threads:[~2013-05-27 19:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27 19:09 [PATCH for 3.10 0/7] brcmfmac: AP and P2P mode fixes Arend van Spriel
2013-05-27 19:09 ` [PATCH for 3.10 1/7] brcmfmac: Turn off ARP offloading when configured for AP Arend van Spriel
2013-05-27 19:09 ` [PATCH for 3.10 2/7] brcmfmac: Fix p2p setup when connected to ap on 5G Arend van Spriel
2013-05-27 19:09 ` [PATCH for 3.10 3/7] brcmfmac: add additional parameter to brcmf_free_vif() Arend van Spriel
2013-05-27 19:09 ` [PATCH for 3.10 4/7] brcmfmac: free net device when registration fails Arend van Spriel
2013-05-27 19:09 ` [PATCH for 3.10 5/7] brcmfmac: use struct net_device::destructor to remove interfaces Arend van Spriel
2013-05-27 19:09 ` [PATCH for 3.10 6/7] brcmfmac: Add multi channel support for P2P Arend van Spriel
2013-05-27 19:09 ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369681799-3163-8-git-send-email-arend@broadcom.com \
    --to=arend@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=meuleman@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox