From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: Arend van Spriel <arend@broadcom.com>,
"hostap@lists.shmoo.com" <hostap@lists.shmoo.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Jithu Jance <jithu@broadcom.com>
Subject: Re: P2P Device support: how to deal with p2p_no_group_iface option
Date: Mon, 27 May 2013 21:15:53 +0200 [thread overview]
Message-ID: <1369682153.14740.27.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130527181112.GA20210@w1.fi>
On Mon, 2013-05-27 at 21:11 +0300, Jouni Malinen wrote:
> On Mon, May 27, 2013 at 03:56:19PM +0200, Arend van Spriel wrote:
> > In this mac80211_hwsim is a special case. We could make P2P_DEVICE
> > support in mac80211_hwsim optional using module parameter to allow
> > testing both cases.
>
> Yes, that would be helpful. I don't understand why my test setup moves
> to using P2P Device by default when mac80211_hwsim is perfectly capable
> of operating without that.. [...]
>
> In general, I don't think it is a good idea to change existing behavior
> with a kernel or wpa_supplicant upgrade. It is obviously fine if this is
> needed for the functionality to work in the first place, but that is not
> the case with mac80211_hwsim.
It's kinda a side effect of having "I support P2P-Device" also mean "I
want P2P-Device to be used", but for everything other than hwsim that
seems like the only reasonable choice, so ... I wouldn't mind changing
the default in hwsim though to not support/desire P2P-Device w/o a
configuration option or so.
johannes
next prev parent reply other threads:[~2013-05-27 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 11:23 P2P Device support: how to deal with p2p_no_group_iface option Arend van Spriel
2013-05-27 9:03 ` Johannes Berg
2013-05-27 13:56 ` Arend van Spriel
2013-05-27 13:59 ` Johannes Berg
2013-05-27 14:03 ` Arend van Spriel
2013-05-27 15:53 ` Johannes Berg
2013-05-27 17:40 ` Arend van Spriel
2013-05-27 18:11 ` Jouni Malinen
2013-05-27 19:15 ` Johannes Berg [this message]
2013-05-27 19:20 ` Arend van Spriel
2013-05-27 19:27 ` Johannes Berg
2013-05-27 18:51 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369682153.14740.27.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=hostap@lists.shmoo.com \
--cc=j@w1.fi \
--cc=jithu@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).