linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] iwlwifi: fix chain noise calibration
@ 2013-05-31  5:29 Nikolay Martynov
  2013-05-31  9:11 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Martynov @ 2013-05-31  5:29 UTC (permalink / raw)
  To: johannes.berg, wey-yi.w.guy; +Cc: ilw, linux-wireless, Nikolay Martynov

First step of chain noise calibration process had disable flag check inverted.
Chain noise calibration never started because of this.

Tested on intel 5300 with two antennas attached. Driver correctly disabled one chain.

Signed-off-by: Nikolay Martynov <mar.kolya@gmail.com>
---
 drivers/net/wireless/iwlwifi/dvm/rxon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/iwlwifi/dvm/rxon.c b/drivers/net/wireless/iwlwifi/dvm/rxon.c
index 707446f..cd1ad001 100644
--- a/drivers/net/wireless/iwlwifi/dvm/rxon.c
+++ b/drivers/net/wireless/iwlwifi/dvm/rxon.c
@@ -1378,7 +1378,7 @@ static void iwlagn_chain_noise_reset(struct iwl_priv *priv)
 	struct iwl_chain_noise_data *data = &priv->chain_noise_data;
 	int ret;
 
-	if (!(priv->calib_disabled & IWL_CHAIN_NOISE_CALIB_DISABLED))
+	if (priv->calib_disabled & IWL_CHAIN_NOISE_CALIB_DISABLED)
 		return;
 
 	if ((data->state == IWL_CHAIN_NOISE_ALIVE) &&
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iwlwifi: fix chain noise calibration
  2013-05-31  5:29 [PATCH] iwlwifi: fix chain noise calibration Nikolay Martynov
@ 2013-05-31  9:11 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2013-05-31  9:11 UTC (permalink / raw)
  To: Nikolay Martynov; +Cc: wey-yi.w.guy, ilw, linux-wireless

T24gRnJpLCAyMDEzLTA1LTMxIGF0IDAxOjI5IC0wNDAwLCBOaWtvbGF5IE1hcnR5bm92IHdyb3Rl
Ogo+IEZpcnN0IHN0ZXAgb2YgY2hhaW4gbm9pc2UgY2FsaWJyYXRpb24gcHJvY2VzcyBoYWQgZGlz
YWJsZSBmbGFnIGNoZWNrIGludmVydGVkLgo+IENoYWluIG5vaXNlIGNhbGlicmF0aW9uIG5ldmVy
IHN0YXJ0ZWQgYmVjYXVzZSBvZiB0aGlzLgo+IAo+IFRlc3RlZCBvbiBpbnRlbCA1MzAwIHdpdGgg
dHdvIGFudGVubmFzIGF0dGFjaGVkLiBEcml2ZXIgY29ycmVjdGx5IGRpc2FibGVkIG9uZSBjaGFp
bi4KCkh1aCwgdGhpcyBidWcgbXVzdCBoYXZlIGJlZW4gdGhlcmUgZm9yIGEgbG9uZyB0aW1lIC4u
IHRoYW5rcywgYXBwbGllZCEKCmpvaGFubmVzCgpJbnRlbCBHbWJICkRvcm5hY2hlciBTdHJhc3Nl
IDEKODU2MjIgRmVsZGtpcmNoZW4vTXVlbmNoZW4sIERldXRzY2hsYW5kClNpdHogZGVyIEdlc2Vs
bHNjaGFmdDogRmVsZGtpcmNoZW4gYmVpIE11ZW5jaGVuCkdlc2NoYWVmdHNmdWVocmVyOiBDaHJp
c3RpYW4gTGFtcHJlY2h0ZXIsIEhhbm5lcyBTY2h3YWRlcmVyLCBEb3VnbGFzIEx1c2sKUmVnaXN0
ZXJnZXJpY2h0OiBNdWVuY2hlbiBIUkIgNDc0NTYKVXN0Li1JZE5yLi9WQVQgUmVnaXN0cmF0aW9u
IE5vLjogREUxMjkzODU4OTUKQ2l0aWJhbmsgRnJhbmtmdXJ0IGEuTS4gKEJMWiA1MDIgMTA5IDAw
KSA2MDAxMTkwNTIK


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-31  9:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-31  5:29 [PATCH] iwlwifi: fix chain noise calibration Nikolay Martynov
2013-05-31  9:11 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).